From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751820AbcANIaz (ORCPT ); Thu, 14 Jan 2016 03:30:55 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:34075 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750837AbcANIax (ORCPT ); Thu, 14 Jan 2016 03:30:53 -0500 Subject: Re: [PATCH] uapi: update install list after nvme.h rename To: linux-kernel@vger.kernel.org, hch@lst.de, keith.busch@intel.com, axboe@fb.com, stable@vger.kernel.org References: <1452474851-386-1-git-send-email-vapier@gentoo.org> <5694BD46.3030004@suse.cz> <20160114011720.GT4894@vapier.lan> <56975BA7.10905@suse.cz> Cc: Michal Marek , Kernel Build Daemon , Fengguang Wu , kbuild-all@01.org From: Jiri Slaby Message-ID: <56975CB9.6020700@suse.cz> Date: Thu, 14 Jan 2016 09:30:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56975BA7.10905@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 01/14/2016, 09:26 AM, Jiri Slaby wrote: > On 01/14/2016, 02:17 AM, Mike Frysinger wrote: >> On 12 Jan 2016 09:45, Jiri Slaby wrote: >>> On 01/11/2016, 02:14 AM, Mike Frysinger wrote: >>>> Commit 9d99a8dda154 ("nvme: move hardware structures out of >>>> the uapi version of nvme.h") renamed nvme.h to nvme_ioctl.h, >>>> but the uapi list still refers to nvme.h. People trying to >>>> install the headers hit a failure as the header no longer >>>> exists. >>> >>> Wouldn't reverting the rename be nicer to userspace? So that >>> the filename is preserved and anybody who #included nvme.h >>> still can do so? > >> i have no opinion on either route > >> on a related note, shouldn't headers install be part of the >> automatic kernel checks that are run against repos on kernel.org >> ? who runs that thing ? ^^^^^ You have Fengguang's 0-day build robot on your mind? (CCed) > I have been thinking about at least 'test -f' for all 'headers-y' > during make all. What do you think, Michal? - -- js suse labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWl1y5AAoJEL0lsQQGtHBJz/YP/27RtFl7wjkyhwY935/2FQeM XmZ0/WUz2vJdMT6MNC8+cwZ5Vfua7SgNbXh8wLkzDxBufc3vBe3eugfTmrn4kAsL GglaCDCvI5tduWVwV2CPvr1fSc9Jazj89OQld7+VhqIbKFxY4WkhWV06tHKUEPXd 2vgtSwsY4ka0CLWgdAsJZfdhBIG7tBwrlgxaWGf/kcUCRz9cavNt8FWGXUGWHnDI J8h6eGld8TJPzvYEdHQD/MlAf/7Kle0m5MhMy+uUHdFrDWPrwqMLTDburcHyh59v QatkLXyn7yZ2NeqPdF8FHW7Mp+A5oP+exSme7TYmKZzMNmwdx8um+gjUcd2Aq6LB n/IhZp5rZBaPU6/CgYKvwy+jGPfkDI1WITO3YQlCkc/SzdvhjufgAFZ7MGYVA3NZ iKsSMIi33ncN7D7TNevkPlHylp8HSx91girRtp0sP7cO2INRCl98SSiL9bq+a1Vm tc3t64QE1YJ7/gsQ1/sfjVZIQ5sFNzTn9I4KpDWPkSWaOTl3ikULwxhop1touTdq BGq+kVB20/cmt7sUNc4dieM97mlMD55vT3QQ1qyuUsyAdrdWE4npxo5OE43YBORL /a8KJVscITLq7OK/QwlPi0wbSFlfGOe3LtFS8CqVWRBhQ+3Udy4eL4m7d9cB0Ats ChQQpLBSRpN3sjuypY8d =8T96 -----END PGP SIGNATURE-----