From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55475)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chengang@emindsoft.com.cn>) id 1aJdmv-0004sN-GO
	for qemu-devel@nongnu.org; Thu, 14 Jan 2016 04:01:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chengang@emindsoft.com.cn>) id 1aJdmq-0003Hi-F3
	for qemu-devel@nongnu.org; Thu, 14 Jan 2016 04:01:49 -0500
Received: from out1134-249.mail.aliyun.com ([42.120.134.249]:65479)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chengang@emindsoft.com.cn>) id 1aJdmq-0003GK-1X
	for qemu-devel@nongnu.org; Thu, 14 Jan 2016 04:01:44 -0500
References: <1452752664-11818-1-git-send-email-chengang@emindsoft.com.cn>
	<5697593A.5020304@vivier.eu>
From: Chen Gang <chengang@emindsoft.com.cn>
Message-ID: <569763EF.3010702@emindsoft.com.cn>
Date: Thu, 14 Jan 2016 17:01:35 +0800
MIME-Version: 1.0
In-Reply-To: <5697593A.5020304@vivier.eu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let lv always match
 val in do_getsockopt()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <laurent@vivier.eu>, riku.voipio@iki.fi
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, rth@twiddle.net

On 2016年01月14日 16:15, Laurent Vivier wrote:
> Le 14/01/2016 07:24, chengang@emindsoft.com.cn a écrit :
>> From: Chen Gang <chengang@emindsoft.com.cn>
>>
>> After host_to_target_sock_type(), the length of val may be changed, so
>> calculate the related lv, too.
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>>  linux-user/syscall.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
>> index fcdca2a..0e95f35 100644
>> --- a/linux-user/syscall.c
>> +++ b/linux-user/syscall.c
>> @@ -1841,6 +1841,7 @@ static abi_long do_getsockopt(int sockfd, int level, int optname,
>>              return ret;
>>          if (optname == SO_TYPE) {
>>              val = host_to_target_sock_type(val);
>> +            lv = (val >> 8) ? 4 : 1;
> 
> It seems the kernel always returns sizeof(int) (for all archs), what is
> the aim of reducing the size ?
> 

I am not quite sure whether kernel always returns sizeof(int) (I guess,
it should be).

For me, if you are sure, we can skip this patch.

Thanks.
-- 
Chen Gang (陈刚)

Open, share, and attitude like air, water, and life which God blessed