From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410 Date: Thu, 14 Jan 2016 01:54:07 -0800 Message-ID: <5697703F.8040801@roeck-us.net> References: <1452531649-14940-1-git-send-email-linux@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Kukjin Kim , Krzysztof Kozlowski , Russell King , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , "linux-kernel@vger.kernel.org" List-Id: linux-samsung-soc@vger.kernel.org On 01/14/2016 01:02 AM, Linus Walleij wrote: > On Mon, Jan 11, 2016 at 6:00 PM, Guenter Roeck wrote: > >> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"), >> all users of struct bgpio_pdata depend on GPIO_GENERIC. >> >> This results in the following build error. >> >> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: >> excess elements in struct initializer >> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: >> (near initialization for '(anonymous)') >> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error: >> invalid use of undefined type 'struct bgpio_pdata' >> >> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct") >> Cc: Linus Walleij >> Signed-off-by: Guenter Roeck >> --- >> I don't know if this is the correct way to fix this problem. >> If not, please consider this to be a bug report. > > I think this is fixed by Arnds patch: > http://marc.info/?l=linux-gpio&m=145237423205247&w=2 > > Can you verify that? > Correct. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@roeck-us.net (Guenter Roeck) Date: Thu, 14 Jan 2016 01:54:07 -0800 Subject: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410 In-Reply-To: References: <1452531649-14940-1-git-send-email-linux@roeck-us.net> Message-ID: <5697703F.8040801@roeck-us.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/14/2016 01:02 AM, Linus Walleij wrote: > On Mon, Jan 11, 2016 at 6:00 PM, Guenter Roeck wrote: > >> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"), >> all users of struct bgpio_pdata depend on GPIO_GENERIC. >> >> This results in the following build error. >> >> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: >> excess elements in struct initializer >> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: >> (near initialization for '(anonymous)') >> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error: >> invalid use of undefined type 'struct bgpio_pdata' >> >> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct") >> Cc: Linus Walleij >> Signed-off-by: Guenter Roeck >> --- >> I don't know if this is the correct way to fix this problem. >> If not, please consider this to be a bug report. > > I think this is fixed by Arnds patch: > http://marc.info/?l=linux-gpio&m=145237423205247&w=2 > > Can you verify that? > Correct. Guenter