From: Edward Cree <ecree@solarflare.com>
To: Alexander Duyck <aduyck@mirantis.com>, <netdev@vger.kernel.org>,
<tom@herbertland.com>
Subject: Re: [RFC PATCH 3/4] net: Store checksum result for offloaded GSO checksums
Date: Thu, 14 Jan 2016 12:02:33 +0000 [thread overview]
Message-ID: <56978E59.4070406@solarflare.com> (raw)
In-Reply-To: <20160114051214.5119.63241.stgit@localhost.localdomain>
On 14/01/16 05:12, Alexander Duyck wrote:
> In order to do that I replaced CHECKSUM_PARTIAL with
> CHECKSUM_UNNECESSARY in the case of us computing checksums for the outer
> header while skipping computing checksums for the inner headers. We clean
> up the ip_summed flag and set it to either CHECKSUM_PARTIAL or
> CHECKSUM_NONE once we hand the packet off to the next lower level.
I feel like this should probably be mentioned in the comment at thetop of
skbuff.h. I think section E of that comment will need to be more or less
completely re-written with this patch series. In particular, if I'm
understandingcorrectly, csum_start and csum_offset will point to the
inner checksum (unless using RCO), same as they do without GSO. And GSO
will never offload multiple checksums (although TSO will still have to
_edit_ multiple checksums).
Or better still, proper documentation of GSO and TSO would be nice :)
next prev parent reply other threads:[~2016-01-14 12:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 5:11 [RFC PATCH 0/4] Implement local checksum offload support for tunnel segmentation Alexander Duyck
2016-01-14 5:12 ` [RFC PATCH 1/4] net: Move GSO csum into SKB_GSO_CB Alexander Duyck
2016-01-14 11:10 ` Edward Cree
2016-01-14 5:12 ` [RFC PATCH 2/4] net: Update remote checksum segmentation to support use of GSO checksum Alexander Duyck
2016-01-14 5:12 ` [RFC PATCH 3/4] net: Store checksum result for offloaded GSO checksums Alexander Duyck
2016-01-14 12:02 ` Edward Cree [this message]
2016-01-14 5:12 ` [RFC PATCH 4/4] net: Allow UDP and GRE to use inner checksum offloads with outer checksums needed Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56978E59.4070406@solarflare.com \
--to=ecree@solarflare.com \
--cc=aduyck@mirantis.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.