From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [OSSTEST PATCH] enable FLASK_ENABLE when using it for testing Date: Thu, 14 Jan 2016 10:34:57 -0600 Message-ID: <5697CE31.4080706@cardoe.com> References: <1452783526-29173-1-git-send-email-cardoe@cardoe.com> <1452788576.32341.8.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6545149984220265126==" Return-path: In-Reply-To: <1452788576.32341.8.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============6545149984220265126== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uSlXptjCCOw4c4owBG5FmbJpw1v6VpEGq" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uSlXptjCCOw4c4owBG5FmbJpw1v6VpEGq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 1/14/16 10:22 AM, Ian Campbell wrote: > On Thu, 2016-01-14 at 08:58 -0600, Doug Goldstein wrote: >> Currently OSSTest has 'XSM' tests but XSM and FLASK are two different >> options and OSSTests's 'XSM' test depends on FLASK so ensure that FLAS= K >> is enabled so that tests pass. >=20 > IMHO the xen/Kconfig should be arranged such that if XSM is enabled the= n > FLASK is on by default. Having XSM but not Flask as what happens if you= > enable XSM isn't helpful. That is how its setup. But a test framework should be explicit over implicit over behaviors. >=20 > However, xen/common/Kconfig already has "default y" and "depends XSM" f= or > the FLASK entry, which I would have said was what was required to behav= e as > I suggest. >=20 > So why isn't it I wonder? It is. If the test framework enabled FLASK since its testing FLASK then I would agree with you. I'd actually argue that my patch didn't go far enough and change all the places to FLASK instead of XSM. >=20 > After a plain "make -C xen defconfig" I end up with a xen/.config > containing "CONFIG_XSM is not set" and no mention of CONFIG_FLASK (as > expected, due to the depends). >=20 > Adding CONFIG_XSM=3Dy to the end of xen/.config and running "make -C xe= n > oldconfig" I then get asked: >=20 > FLux Advanced Security Kernel support (FLASK) [Y/n/?] (NEW) =20 >=20 > IOW it does appear to be defaulting to on (I also get asked about > LATE_HWDOM). >=20 > osstest uses "olddefconfig", and with: >=20 > $ make -C xen olddefconfig > $ echo 'CONFIG_XSM=3Dy' >> xen/.config =20 > $ make -C xen olddefconfig >=20 > I end up with both XSM and FLASK enabled: >=20 > $ grep -E XSM\|FLASK xen/.config > CONFIG_FLASK=3Dy > CONFIG_XSM=3Dy >=20 > which is what we want and is expected etc. Looking at the results of th= e > latest xen-unstable http://logs.test-lab.xenproject.org/osstest/logs/77= 945/ > and specifically at > http://logs.test-lab.xenproject.org/osstest/logs/77945/build-amd64-xsm/= build/xen-hv-config > it seems that the automated version is doing what is expected too. IOW = this > patch is both unnecessary (since it already works) and wrong (since it = is > working how we want it to) and the issue exhibited by the test cases in= > 77945 is something different. >=20 > Ian. >=20 This patch is for the tooling. The point of the patch is to be explicit over implicit defaults. FLASK depends on XSM. The test framework tests FLASK. It was relying on the behavior that FLASK is defaulted to enabled when XSM is enabled but if it wants to test FLASK it should turn on FLASK= =2E --=20 Doug Goldstein --uSlXptjCCOw4c4owBG5FmbJpw1v6VpEGq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWl840XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUALMQAJMCWNxrodTTWdsQFx3j28Yz FYZ3cOhAkJ/rFBC0g3c/RvDJ1tpRpXqMyF1+2NJhUJ6RqNBzQHCkmxsBFD8nqzUX QVpJ/4JYxfUhC+UrdyMX2TYLWVA+Ubk6LGfgjjsDDEw5ywThXwtfjrzeorptAnl7 WdmAvbiYog4MP+dveyRSISHP4B7UgwxcNT4D+ox9OqmzYZI1fLVOpYQoRftviQ0M e6GCEd2TuzfARrT0PIUVFW1LIxZfPqovAKlx7qYDtVrIayKwgX/wfNlFQIwIIu4V xSHNU381+L8WyYmWoTXMg3cNXiFwAsQbLGb9Z+LEJbK1J6twRzaV7CmJz/FC3tmh nzie28v3rZPsoY/UFxwMuWRYftYQHYxgzEpXmxjA110Nr4iuaRNW0K5kxkE9WYK8 IhX4qAmoojibQOK06vxYreCoLoFCHVNH1M7wbLVQv+KloSWHVmnCmxyu+2mPD7Vb KTlmpdX1Ypa+OlhYnz5RzS6AEzwFZamrFRDHn3f6dM2db+/BUT4u8SplsXR8bVl2 YB/aYB6PWTpfuft5VWd8++AXYu9/s0JOW81QO8mTRjG4LrOGdr1/nYagAkyLDnG3 XRDYe5lfCzOHi17dhq6mbAyEO5+rqSq++g4LpDS/MWIi/LGVGfnnlxFSYefjxohf T++EXa4ldJ9pdrQwBB4P =DjyF -----END PGP SIGNATURE----- --uSlXptjCCOw4c4owBG5FmbJpw1v6VpEGq-- --===============6545149984220265126== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6545149984220265126==--