From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] docs/qapi-code-gen.txt: Fix simple union introspection example
Date: Thu, 14 Jan 2016 09:39:14 -0700 [thread overview]
Message-ID: <5697CF32.9090108@redhat.com> (raw)
In-Reply-To: <1452784405-7097-1-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On 01/14/2016 08:13 AM, Markus Armbruster wrote:
> The implicit tag member is named "type", not "kind". Screwed up in
> commit 39a1815.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> docs/qapi-code-gen.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
However, there's other errors in the documentation (we haven't kept it
up-to-date with recent churn in the generator), so maybe it's better to
fix all of them at once. See my Subset E series:
https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03863.html
https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg00410.html
(I'll probably have to send a v9 of the series, but wanted to see if you
had any comments on v8 first)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-01-14 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 15:13 [Qemu-devel] [PATCH] docs/qapi-code-gen.txt: Fix simple union introspection example Markus Armbruster
2016-01-14 16:39 ` Eric Blake [this message]
2016-01-15 9:25 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5697CF32.9090108@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.