From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030185AbcANRpI (ORCPT ); Thu, 14 Jan 2016 12:45:08 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:42526 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756341AbcANRpF (ORCPT ); Thu, 14 Jan 2016 12:45:05 -0500 Message-ID: <5697DE9D.2040003@collabora.co.uk> Date: Thu, 14 Jan 2016 17:45:01 +0000 From: Martyn Welch User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 Newsgroups: gmane.linux.kernel,gmane.linux.usb.general To: Konstantin Shkolnyy , johan@kernel.org CC: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/4] USB: serial: cp210x: Switch to new 8-bit and 32-bit register access functions. References: <1451704340-11976-1-git-send-email-konstantin.shkolnyy@gmail.com> In-Reply-To: <1451704340-11976-1-git-send-email-konstantin.shkolnyy@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/01/16 03:12, Konstantin Shkolnyy wrote: > Change to use new 8-bit and 32-bit register access functions instead of > cp210x_get_config and cp210x_set_config. > > Signed-off-by: Konstantin Shkolnyy Acked-by: Martyn Welch > --- > change in v3: Presented new function addition as a separate patch #1, > to simplify code review. > > drivers/usb/serial/cp210x.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c > index 7a91c6c..1339d77 100644 > --- a/drivers/usb/serial/cp210x.c > +++ b/drivers/usb/serial/cp210x.c > @@ -787,10 +787,10 @@ static void cp210x_get_termios_port(struct usb_serial_port *port, > { > struct device *dev = &port->dev; > unsigned int cflag, modem_ctl[4]; > - unsigned int baud; > + u32 baud; > u16 bits; > > - cp210x_get_config(port, CP210X_GET_BAUDRATE, &baud, 4); > + cp210x_read_u32_reg(port, CP210X_GET_BAUDRATE, &baud); > > dev_dbg(dev, "%s - baud rate = %d\n", __func__, baud); > *baudp = baud; > @@ -937,8 +937,7 @@ static void cp210x_change_speed(struct tty_struct *tty, > baud = cp210x_quantise_baudrate(baud); > > dev_dbg(&port->dev, "%s - setting baud rate to %u\n", __func__, baud); > - if (cp210x_set_config(port, CP210X_SET_BAUDRATE, &baud, > - sizeof(baud))) { > + if (cp210x_write_u32_reg(port, CP210X_SET_BAUDRATE, baud)) { > dev_warn(&port->dev, "failed to set baud rate to %u\n", baud); > if (old_termios) > baud = old_termios->c_ospeed; > @@ -1109,10 +1108,10 @@ static void cp210x_dtr_rts(struct usb_serial_port *p, int on) > static int cp210x_tiocmget(struct tty_struct *tty) > { > struct usb_serial_port *port = tty->driver_data; > - unsigned int control; > + u8 control; > int result; > > - cp210x_get_config(port, CP210X_GET_MDMSTS, &control, 1); > + cp210x_read_u8_reg(port, CP210X_GET_MDMSTS, &control); > > result = ((control & CONTROL_DTR) ? TIOCM_DTR : 0) > |((control & CONTROL_RTS) ? TIOCM_RTS : 0) >