From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756693AbcANSXb (ORCPT ); Thu, 14 Jan 2016 13:23:31 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:42576 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752068AbcANSXa (ORCPT ); Thu, 14 Jan 2016 13:23:30 -0500 Message-ID: <5697E79E.7080500@collabora.co.uk> Date: Thu, 14 Jan 2016 18:23:26 +0000 From: Martyn Welch User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Konstantin Shkolnyy , Konstantin Shkolnyy , "johan@kernel.org" CC: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 2/4] USB: serial: cp210x: Switch to new 16-bit register access functions. References: <1451704323-11941-1-git-send-email-konstantin.shkolnyy@gmail.com> <5697DE45.7000204@collabora.co.uk> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/01/16 18:22, Konstantin Shkolnyy wrote: >> -----Original Message----- >> From: linux-usb-owner@vger.kernel.org [mailto:linux-usb- >> owner@vger.kernel.org] On Behalf Of Martyn Welch >> Sent: Thursday, January 14, 2016 11:44 >> To: Konstantin Shkolnyy; johan@kernel.org >> Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v3 2/4] USB: serial: cp210x: Switch to new 16-bit register >> access functions. > ... > >>> @@ -697,14 +685,11 @@ static unsigned int >> cp210x_quantise_baudrate(unsigned int baud) >>> >>> static int cp210x_open(struct tty_struct *tty, struct usb_serial_port *port) >>> { >>> - int result; >>> + int err; >>> >>> - result = cp210x_set_config_single(port, CP210X_IFC_ENABLE, >>> - >> UART_ENABLE); >>> - if (result) { >>> - dev_err(&port->dev, "%s - Unable to enable UART\n", >> __func__); >>> - return result; >>> - } >>> + err = cp210x_write_u16_reg(port, CP210X_IFC_ENABLE, >> UART_ENABLE); >>> + if (err) >>> + return err; >> >> Any reason for dropping the error message? > > I already print a message if the underlying usb_control_msg fails, so it should be covered there. > Sounds like a very valid reason :-) Martyn