All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH RT] net: move xmit_recursion to per-task variable on -RT
Date: Thu, 14 Jan 2016 23:02:09 +0100	[thread overview]
Message-ID: <56981AE1.20202@stressinduktion.org> (raw)
In-Reply-To: <20160114145007.GC17776@linutronix.de>

On 14.01.2016 15:50, Sebastian Andrzej Siewior wrote:
> * Thomas Gleixner | 2016-01-13 18:31:46 [+0100]:
>
>> On Wed, 13 Jan 2016, Sebastian Andrzej Siewior wrote:
>>> +#ifdef CONFIG_PREEMPT_RT_FULL
>>> +static inline int dev_recursion_level(void)
>>> +{
>>> +	return atomic_read(&current->xmit_recursion);
>>
>> Why would you need an atomic here. current does hardly race against itself.
>
> right.

We are just adding a second recursion limit solely to openvswitch which 
has the same problem:

https://patchwork.ozlabs.org/patch/566769/

This time also we depend on rcu_read_lock marking the section being 
nonpreemptible. Nice would be a more generic solution here which doesn't 
need to always add something to *current.

Thanks,
Hannes

  reply	other threads:[~2016-01-14 22:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13 15:23 [PATCH RT] net: move xmit_recursion to per-task variable on -RT Sebastian Andrzej Siewior
2016-01-13 17:31 ` Thomas Gleixner
2016-01-14 14:50   ` Sebastian Andrzej Siewior
2016-01-14 22:02     ` Hannes Frederic Sowa [this message]
2016-01-14 22:20       ` Eric Dumazet
2016-01-14 23:00         ` Hannes Frederic Sowa
2016-01-15  8:21           ` Thomas Gleixner
2016-01-15  9:34             ` Hannes Frederic Sowa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56981AE1.20202@stressinduktion.org \
    --to=hannes@stressinduktion.org \
    --cc=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.