From: Eric Blake <eblake@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 0/5] Xen PCI passthru: Convert to realize()
Date: Thu, 14 Jan 2016 15:36:17 -0700 [thread overview]
Message-ID: <569822E1.7070304@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1601141650290.16178@kaball.uk.xensource.com>
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
On 01/14/2016 09:50 AM, Stefano Stabellini wrote:
> Eric,
>
> I'll wait for your reviewed-by on the whole series before committing.
Found a bug in 2/5, up to you if you want to fix that or wait for a v6.
> On Wed, 13 Jan 2016, Cao jin wrote:
>> v5 changelog:
>> 1. tweaked the commit message of patch 1/5 as sugguested.
>> 2. xen_host_pci_sysfs_path() modification as sugguested.
>> 3. remove local 'value' variable in xen_host_pci_get_value()
Basically, this change from v4 was not correct, after all.
>> 4. Indentation fix in patch 2/5.
>> 5. Still use error_append_hint() because error_prepend() doesn`t exist.
But it does now: commit 8277d2aa.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-01-14 22:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 12:51 [Qemu-devel] [PATCH v5 0/5] Xen PCI passthru: Convert to realize() Cao jin
2016-01-13 12:51 ` [Qemu-devel] [PATCH v5 1/5] Xen: use qemu_strtoul instead of strtol Cao jin
2016-01-14 22:19 ` Eric Blake
2016-01-13 12:51 ` [Qemu-devel] [PATCH v5 2/5] Add Error **errp for xen_host_pci_device_get() Cao jin
2016-01-14 22:29 ` Eric Blake
2016-01-15 3:11 ` Cao jin
2016-01-15 16:41 ` Eric Blake
2016-01-17 10:34 ` Cao jin
2016-01-13 12:51 ` [Qemu-devel] [PATCH v5 3/5] Add Error **errp for xen_pt_setup_vga() Cao jin
2016-01-14 22:31 ` Eric Blake
2016-01-13 12:51 ` [Qemu-devel] [PATCH v5 4/5] Add Error **errp for xen_pt_config_init() Cao jin
2016-01-14 22:32 ` Eric Blake
2016-01-13 12:51 ` [Qemu-devel] [PATCH v5 5/5] Xen PCI passthru: convert to realize() Cao jin
2016-01-14 22:34 ` Eric Blake
2016-01-14 16:50 ` [Qemu-devel] [PATCH v5 0/5] Xen PCI passthru: Convert " Stefano Stabellini
2016-01-14 22:36 ` Eric Blake [this message]
2016-01-15 14:16 ` Stefano Stabellini
2016-01-17 10:18 ` Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569822E1.7070304@redhat.com \
--to=eblake@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.