From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJraa-0008HC-3V for qemu-devel@nongnu.org; Thu, 14 Jan 2016 18:46:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJraW-0001wR-T5 for qemu-devel@nongnu.org; Thu, 14 Jan 2016 18:46:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59316) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJraW-0001wM-NG for qemu-devel@nongnu.org; Thu, 14 Jan 2016 18:45:56 -0500 References: <1452257883-19549-1-git-send-email-kraxel@redhat.com> From: Eric Blake Message-ID: <56983331.7090206@redhat.com> Date: Thu, 14 Jan 2016 16:45:53 -0700 MIME-Version: 1.0 In-Reply-To: <1452257883-19549-1-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HGkb8vT2OIL0Kd5xExFb7gfqqFnCfp73x" Subject: Re: [Qemu-devel] [PATCH v2] pc: allow raising low memory via max-ram-below-4g option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HGkb8vT2OIL0Kd5xExFb7gfqqFnCfp73x Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/08/2016 05:58 AM, Gerd Hoffmann wrote: > This patch extends the functionality of the max-ram-below-4g option > to also allow increasing lowmem. Use case: Give as much memory as > possible to legacy non-PAE guests. >=20 > While being at it also rework the lowmem calculation logic and add a > longish comment describing how it works and what the compatibility > constrains are. s/constrains/constraints/ >=20 > Signed-off-by: Gerd Hoffmann > --- > + if (lowmem & ((1ULL << 30) - 1)) { > + error_report("Warning: Large machine and max_ram_below= _4g " > + "(%" PRIu64 ") not a multiple of 1G; " > + "possible bad performance.", No trailing '.' in error_report(), please. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HGkb8vT2OIL0Kd5xExFb7gfqqFnCfp73x Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWmDMxAAoJEKeha0olJ0NqPx8H/3MJpAclf2aMdl4CTU7xYeZB 0LETbjC4UiDC92FI1HtPgjKuZ7z+6JulO9/MSB4zshryPLiPQSPwPIJtYZKQwZkn Z2kbC9vh/KEekbAHNBRkVldqwhep7rMb4Gu9M//Vx8swx3IQczFhA4/9+1xYvi1a MrY1ntXEshNvHOBG1U2UQRV+6+Z/tp0IAgi+9qDoodW4aL9MbaVGQY2rKN2v0Ekr B2eLVXYO3iutVcHmT3oE75SxvHdzdhCfD30kKeNZ5NzHVgglcmlnx7WoLfsypxt6 p4QTWmsl4S8WOxJt+KK079F70hLGyHw67uW6xjPvNwYay+mOXogBO7FFTZR91qg= =sevx -----END PGP SIGNATURE----- --HGkb8vT2OIL0Kd5xExFb7gfqqFnCfp73x--