From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJtcs-0000xP-1J for qemu-devel@nongnu.org; Thu, 14 Jan 2016 20:56:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJtco-00060J-Qw for qemu-devel@nongnu.org; Thu, 14 Jan 2016 20:56:29 -0500 References: <1452774233-32423-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1452774233-32423-3-git-send-email-caoj.fnst@cn.fujitsu.com> <5697C1D7.2050309@gmail.com> From: Cao jin Message-ID: <56985275.3030600@cn.fujitsu.com> Date: Fri, 15 Jan 2016 09:59:17 +0800 MIME-Version: 1.0 In-Reply-To: <5697C1D7.2050309@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/2] change type of pci_bridge_initfn() to void List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcel@redhat.com, qemu-devel@nongnu.org Cc: mst@redhat.com, qemu-ppc@nongnu.org, agraf@suse.de, armbru@redhat.com On 01/14/2016 11:42 PM, Marcel Apfelbaum wrote: > On 01/14/2016 02:23 PM, Cao jin wrote: >> diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c >> index 599768e..e9117b9 100644 >> --- a/hw/pci-host/apb.c >> +++ b/hw/pci-host/apb.c >> @@ -636,10 +636,7 @@ static int apb_pci_bridge_initfn(PCIDevice *dev) >> { >> int rc; >> >> - rc = pci_bridge_initfn(dev, TYPE_PCI_BUS); >> - if (rc < 0) { >> - return rc; >> - } >> + pci_bridge_initfn(dev, TYPE_PCI_BUS); >> > > Hi, > > It seems you don't need the rc variable here anymore, right? > > This should break the build (unused local variable), Indeed... > I suggest running configure with no params to check all the architectures, > (I am also running make check while at it, just to be sure) > Thanks for the suggestion, really should that when touched so many device. > Thanks, > Marcel > > . > -- Yours Sincerely, Cao jin