From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752751AbcAOGOu (ORCPT ); Fri, 15 Jan 2016 01:14:50 -0500 Received: from mail-db3on0056.outbound.protection.outlook.com ([157.55.234.56]:46128 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751360AbcAOGOs (ORCPT ); Fri, 15 Jan 2016 01:14:48 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=mika.penttila@nextfour.com; To: LKML From: =?UTF-8?Q?Mika_Penttil=c3=a4?= Subject: [PATCH] arm: fix incorrect bounds check X-Enigmail-Draft-Status: N1110 CC: Message-ID: <56988668.1040803@nextfour.com> Date: Fri, 15 Jan 2016 07:40:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [194.157.170.34] X-ClientProxiedBy: VI1PR05CA0032.eurprd05.prod.outlook.com (25.162.33.170) To VI1PR07MB0910.eurprd07.prod.outlook.com (25.161.108.28) X-Microsoft-Exchange-Diagnostics: 1;VI1PR07MB0910;2:LmnAL2Ko6llNMQh8mvprIappz5VRyvNCtYf0X5uvD6QszAh/Rqa1/6uK5DTM8ydlzsasoMLZU+prqzGECOpeHi470DQeIAwGHXp5yYksc6HceXXshAxnPFKVIpSbEuVYyo97IuVmR7QYiBWJL/n75g==;3:onnKIuE6qncLSFbdzd4LHKONwCOxX/gHzpmS+nU2PedBHF9KJyb1hRM1oOiVcjP0XMJ8HyKe+tbcvIuMYZlinlmsCJpg6kthWF26MFNprkO23Hht591HxlWuuvgWF2mb;25:3TIs/XBakMwGMR1i8SrEyRGltab6eekJxSkifSqXFwID65EpjWAFaSoA9sDuq5hNrthnN8JtasIvEbBCX+As/72b1tkQ72gteidV6he9p0AlU8nPyKZHrYl7yiPtzz55fG41UW0ecy+7UvgsLxIdwONj1fZTKaVaOKMhoq4FmgkTSVuh5+RoPe4BECm099cNfknr7gBIUnBbdlRQKajwJu3akjanNLD2RkvnpHhERmWSY6vb8cWfWUkIxOO97ZpY;4:mUGtGEdDn4UkcTbjFJPnWl80W/0KmWcNO/OY9m4SPdTxJprIXWlpWBK9TYt5wc1SAp1Uys1FtBee/55nmSFzqIChY8nfkyoVW+Wy0KA3iTA60H6pzcCV8017QrHPuoK/ByoEtvhaNdfqM42c7fqYNxaiTS++J4fk+i7zpP4uK8ld1PvsVdfPhMdZaIdbII9aHMAkx+v/3a9tEqFWaYs6QYVAdxkwykmoOuQvtKB12+k2r8Son7Pu87n1c48nseLG+QQYFW/vHwA8WXaMbyJlyGUckJHARCXeTgtSferMiXHXt/5bmdyQcM6UOXk3FSXOdMiTn41JZT3BeSFjaqvy5663C/BmYU+WudwTi8cQG0nTnhp/3QRoYMh9cOpxs0k2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR07MB0910; X-MS-Office365-Filtering-Correlation-Id: e289ffcc-4821-42b3-faf3-08d31d6e73e8 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001)(10201501046);SRVR:VI1PR07MB0910;BCL:0;PCL:0;RULEID:;SRVR:VI1PR07MB0910; X-Forefront-PRVS: 08220FA8D6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(199003)(189002)(47776003)(230700001)(97736004)(6116002)(4326007)(110136002)(5008740100001)(40100003)(3846002)(586003)(4001350100001)(64126003)(117636001)(5001960100002)(229853001)(2906002)(36756003)(81156007)(65956001)(65806001)(189998001)(66066001)(122386002)(19580395003)(50466002)(83506001)(99136001)(77096005)(106356001)(87266999)(59896002)(5004730100002)(105586002)(54356999)(65816999)(92566002)(19580405001)(86362001)(101416001)(50986999)(87976001)(1096002)(23676002)(42186005)(62816006);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR07MB0910;H:[10.10.10.110];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA3TUIwOTEwOzIzOkFYRk11ZWVHSTBUUmlFTzN4dTEvRGh1Zis5?= =?utf-8?B?M0ZZVFhnTyt2THJZc2JNVUZ4OUxCL2ViWUV2bjR1ZitXcW1RditQNmhVczRG?= =?utf-8?B?T1lybzRKK3JrUjZMSUo3WTIvbHpENDB3cEFQOXRPOVJHdzFZc3RDdXFFTCtO?= =?utf-8?B?ZFMrYjg3UVpaQzBHM1hWeHBsRGU4b0FoWXZ6dU94blBnRC9JRU5TdDFHdG8r?= =?utf-8?B?WmtOaVVwL1FhRU0yNVQvZmdvMFVVeWZQRFRmT21TL2pJWDFIL1Z1bnFiRXdq?= =?utf-8?B?dlVzaUZqNUk1d3JReGNuK01jNUp0WnA2VlgrTU96NGNlV0gwQzFlN0Z5YVR2?= =?utf-8?B?S1hMeVlyQ08zL1U2MTliTnpNMnhaSVVxaXNNOHcxMGhFMzFIRHIzbk5nQ3BK?= =?utf-8?B?cjdzN3ZTUVBLUHFuMkZLaTBQMjJ4NDRpbmJ5TW5iUVhOMDMreEdQR0lic0Nh?= =?utf-8?B?M3NWaVg4RnZ0OGY2QjFtRG1JMklvL1oyZXdXUjlEU3B6WUQxdy9GWGxGcVRM?= =?utf-8?B?R2tYeHhEWGZnQVdtOVE2d0JIYkg0blRSRHZDc2pOQWtZU0JKekw5aEwxaCty?= =?utf-8?B?OFg5YVRTZVB5eVpxR0VDVmxURDFVOGVhb053Y0R6NnZaS3ZYNktPald1Vlg2?= =?utf-8?B?ZDUwS1JqcEtuai9sZlhvU0Y2b3FMa3FuTzFPS0crMFc2U1kvZzliWDErQ1Ny?= =?utf-8?B?WEtMK256c2hmWlF1a0pGdHd2OUxkTmZMRXB4SktPdUZEcWR5RHM0bElKelBO?= =?utf-8?B?clVlR1g5bXcxeFYrRTlYQXE0V1VsQW90YXlMbkFMb3ArUVpHNmUrcEJNdE1J?= =?utf-8?B?c08vQ0Y4c0V2ZnZiSVh1U1pJa21aaFRVeDVNSldGeHdHSEp0TDdadGs5d3Y4?= =?utf-8?B?MXRtY0p4RFBnbzZuUG9hL3FOc2orNldDeTVyUWU0NVoxQ2NVakh5YjB4a0dO?= =?utf-8?B?N1l0UlI4QVN5TW5iM1NvdUpTMVhIaU5GVTlialpBajUxd0g1Z0RKSDJrbzMz?= =?utf-8?B?MFFGY1lwY2h1dmJPWFFiOElnU1JUR1Jxa05FS3R4RWJZV1NvQTdKSnNqU2ZJ?= =?utf-8?B?SmNmWGpOUkVLUzAzMk9ERTdwalczRXJEOWxQajdBVXkvOGRsRFMrZHJxQStD?= =?utf-8?B?a2xCd3JtL0FHK2M1WWZtM2JUMm9FZ1R1UFJLZ0FpWHBQcE9rS0tYWkNwL2ZS?= =?utf-8?B?YWZObzJiR1hxNWMrMVVzZEtkMFdEM1U4ZmZxVTRxUUtQc0FQYjNTcFlMbDUx?= =?utf-8?B?WFZJUkltNVV2WnhuUjFlNnNCQzh4eW9SOHlaTWNrV0lQMVRQNmgycHdFN2di?= =?utf-8?B?VHlWekRBYWhBb1pRQ2RmZndGQzdnbkhEQ3BoZzBaZDIyL2pWT2JvVHpGSlRl?= =?utf-8?B?d3BpVjl2U3FKT2RFRHhxbzBFQzVCdXRjeHhCam00cE9RRzRFWmZtVE1hRCt5?= =?utf-8?B?U1pqRE8rZTlyMUhNcWQ2bkhTelFPNHJQU0E1cUM0ZUF1K0VFeWdOdFl1VEpH?= =?utf-8?B?azZNcjVEVDFZTUpVWWc4WTVSeGVpSXVkS1J1UStYcjdLeGNsMHlDYTF5ZXB3?= =?utf-8?B?YXZ2RnF4ZlB1VjlsajFhU284RkFuZk12YTdMTWE5YWNsc1VMRXFTZ0FCQ3Mv?= =?utf-8?B?YklDTmQ3YUlJNFpzNi95K1AxM0p6QnhxbENjTFZ3dW1HK0I1MGlIZkxzeTJQ?= =?utf-8?Q?ybko4WkOlo7O9fpe5s=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR07MB0910;5:aECsSP1FkNd7wtNS36K0KhjrMLo5SMmZMwEy3kK6oSk+545lwL6HeHQrXmd9rz+Jdm5UHHbEA8Z3rTHNW2BN2/iN1wK+JxitFNaGwN/ts2/2wFNS32VENMQME/YEnztAyAbyRkh17pwMP5vNAg6bjQ==;24:74gCHOO87pxD4R0KFnHYOHLo9r7DDIeY7G710g4y8W//IX2DZxPqdzgsdiH8k+hCdJFvO8PTY5dlRLg2noCCQxP1wORRrhbQmVEThvCh928= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nextfour.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2016 05:41:01.5753 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB0910 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Recent changes (4.4.0+) in module loader triggered oops on ARM. While investigating it found incorrect bounds check. This was not the cause of the oops but incorrect anyway. --Mika Signed-off-by: mika.penttila@nextfour.com --- diff --git a/arch/arm/mm/pageattr.c b/arch/arm/mm/pageattr.c index cf30daf..be7fe4b 100644 --- a/arch/arm/mm/pageattr.c +++ b/arch/arm/mm/pageattr.c @@ -52,7 +52,7 @@ static int change_memory_common(unsigned long addr, int numpages, if (start < MODULES_VADDR || start >= MODULES_END) return -EINVAL; - if (end < MODULES_VADDR || start >= MODULES_END) + if (end < MODULES_VADDR || end >= MODULES_END) return -EINVAL; data.set_mask = set_mask;