From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 3/5] sockets: remove use of QemuOpts from socket_connect
Date: Fri, 15 Jan 2016 10:41:03 -0700 [thread overview]
Message-ID: <56992F2F.8010102@redhat.com> (raw)
In-Reply-To: <1452518225-11751-4-git-send-email-berrange@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
On 01/11/2016 06:17 AM, Daniel P. Berrange wrote:
> The socket_connect method accepts a QAPI SocketAddress object
> which it then turns into QemuOpts before calling the
> inet_connect_opts/unix_connect_opts helper methods. By
> converting the latter to use QAPI SocketAddress directly,
> the QemuOpts conversion step can be eliminated
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> util/qemu-sockets.c | 91 +++++++++++++++++++++--------------------------------
> 1 file changed, 36 insertions(+), 55 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-01-15 17:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 13:17 [Qemu-devel] [PATCH v3 0/5] Convert qemu-socket to use QAPI exclusively Daniel P. Berrange
2016-01-11 13:17 ` [Qemu-devel] [PATCH v3 1/5] sockets: remove use of QemuOpts from header file Daniel P. Berrange
2016-01-11 13:17 ` [Qemu-devel] [PATCH v3 2/5] sockets: remove use of QemuOpts from socket_listen Daniel P. Berrange
2016-01-15 16:50 ` Eric Blake
2016-01-11 13:17 ` [Qemu-devel] [PATCH v3 3/5] sockets: remove use of QemuOpts from socket_connect Daniel P. Berrange
2016-01-15 17:41 ` Eric Blake [this message]
2016-01-11 13:17 ` [Qemu-devel] [PATCH v3 4/5] sockets: remove use of QemuOpts from socket_dgram Daniel P. Berrange
2016-01-15 23:12 ` Eric Blake
2016-01-11 13:17 ` [Qemu-devel] [PATCH v3 5/5] vnc: distiguish between ipv4/ipv6 omitted vs set to off Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56992F2F.8010102@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.