From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK8ZB-0007gp-3Y for qemu-devel@nongnu.org; Fri, 15 Jan 2016 12:53:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK8Z7-0007XY-3L for qemu-devel@nongnu.org; Fri, 15 Jan 2016 12:53:41 -0500 Received: from s16892447.onlinehome-server.info ([82.165.15.123]:46311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK8Z6-0007XM-TS for qemu-devel@nongnu.org; Fri, 15 Jan 2016 12:53:37 -0500 References: <1452516028-25218-1-git-send-email-peter.maydell@linaro.org> <56992647.1080409@ilande.co.uk> From: Mark Cave-Ayland Message-ID: <56993201.60603@ilande.co.uk> Date: Fri, 15 Jan 2016 17:53:05 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/8] target-sparc: Update to use VMStateDescription List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Juan Quintela , Patch Tracking , QEMU Developers , Blue Swirl , Amit Shah , Paolo Bonzini On 15/01/16 17:07, Peter Maydell wrote: > On 15 January 2016 at 17:03, Mark Cave-Ayland > wrote: >> I've just run through some SPARC32 tests with this patchset applied - >> testing a savevm/loadvm pair pre-patch and post-patch, and then a few >> random tests with various OSs at random points during boot and no >> regressions here, so: >> >> Tested-by: Mark Cave-Ayland > > Thanks. > >> The only minor nit I could see during review was that both patches 7 and >> 8 bump the VMState revision for SPARC64, and given that before the last >> patch in the set nothing works then is it just worth bumping once to >> version 8 in patch 7 and let that be it? > > My general feeling is that there isn't a significant shortage > of positive integers that would lead us to want to conserve them :-) > If you prefer only bumping once you can do that when you apply the > patches to your target-sparc queue if you like. Ha well if no-one minds too much then I'm not too worried either :) >>From the cover letter it sounds like you've got some further QOM clean-ups waiting on this, so I'll get it merged and queued shortly. ATB, Mark.