From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] tools: make build of FLASK utils/policy explicit Date: Sat, 16 Jan 2016 14:54:31 -0600 Message-ID: <569AAE07.1030108@cardoe.com> References: <1452807355-7670-1-git-send-email-cardoe@cardoe.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5621398898006444808==" Return-path: In-Reply-To: <1452807355-7670-1-git-send-email-cardoe@cardoe.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Wei Liu , Daniel De Graaf , Ian Jackson , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============5621398898006444808== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="V4NAdrLBvMfBqXHPn8nfTDg1OSWNx4eIg" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --V4NAdrLBvMfBqXHPn8nfTDg1OSWNx4eIg Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 1/14/16 3:35 PM, Doug Goldstein wrote: > This patch makes the generation of the FLASK utilities and the policy > explicit. This drops the two control knobs that affect how the FLASK > policy and tools are generated and unifies it under one. >=20 > CC: Ian Jackson > CC: Stefano Stabellini > CC: Ian Campbell > CC: Wei Liu > CC: Daniel De Graaf > Signed-off-by: Doug Goldstein > --- >=20 > So this patch is a replacement for: > http://lists.xenproject.org/archives/html/xen-devel/2015-12/msg02538.ht= ml >=20 > This drops the old "xsmpolicy" flag for one which hopefully makes it mo= re > clear that its building the FLASK policy. It also builds the utilities > only when the new flag is specified. The idea here is to reduce the num= ber > of knobs to turn and provide more clarity in the process. While this is= > an end-user change it should have no effect on the defaults since Xen d= oes > not build with XSM/FLASK by default. Most distros I checked provide a > "xen-tools" package and "xen hypervisor" package so the fact that the k= nobs > are separated should not affect their workflow in any meaningful fashio= n. > The goal here is clarity. The hypervisor now saves how its configured i= n > its .config file (different from the top level Xen .config) in > /usr/lib/debug and in the future the tools stack could provide info abo= ut > how it was configured or built ala: pkg-config --variable udevdir udev >=20 > There's another way to do this patch that I'm also submitting just to > generate discussion. But I'm hoping at the end of the discussion we can= > land one of these patches. >=20 > --- > INSTALL | 4 ++-- > config/Tools.mk.in | 2 +- > tools/Makefile | 2 +- > tools/configure.ac | 2 +- > tools/flask/Makefile | 3 +-- > 5 files changed, 6 insertions(+), 7 deletions(-) >=20 > diff --git a/INSTALL b/INSTALL > index 3d2e86a..e8cbdfa 100644 > --- a/INSTALL > +++ b/INSTALL > @@ -82,8 +82,8 @@ them ocaml development packages must be installed. If= they are missing > configure will automatically disable this option. > --disable-ocamltools > =20 > -Disable XSM policy compilation. > - --disable-xsmpolicy > +Enable FLASK policy and tools build for XSM > + --enable-flask > =20 > Attempt to build of an OVMF firmware binary. This requires special > versions of development tools. Use at your own risk. > diff --git a/config/Tools.mk.in b/config/Tools.mk.in > index ccfe137..699526f 100644 > --- a/config/Tools.mk.in > +++ b/config/Tools.mk.in > @@ -50,7 +50,7 @@ GIT_HTTP :=3D @githttp@ > # Optional components > XENSTAT_XENTOP :=3D @monitors@ > OCAML_TOOLS :=3D @ocamltools@ > -FLASK_POLICY :=3D @xsmpolicy@ > +CONFIG_FLASK :=3D @flask@ > CONFIG_OVMF :=3D @ovmf@ > CONFIG_ROMBIOS :=3D @rombios@ > CONFIG_SEABIOS :=3D @seabios@ > diff --git a/tools/Makefile b/tools/Makefile > index 9f74ac7..41aa102 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -5,7 +5,7 @@ SUBDIRS-y :=3D > SUBDIRS-y +=3D include > SUBDIRS-y +=3D libs > SUBDIRS-y +=3D libxc > -SUBDIRS-$(FLASK_ENABLE) +=3D flask > +SUBDIRS-$(CONFIG_FLASK) +=3D flask > SUBDIRS-y +=3D xenstore > SUBDIRS-y +=3D misc > SUBDIRS-y +=3D examples > diff --git a/tools/configure.ac b/tools/configure.ac > index 6c70040..5caa3ec 100644 > --- a/tools/configure.ac > +++ b/tools/configure.ac > @@ -80,7 +80,7 @@ AX_ARG_DEFAULT_DISABLE([rpath], [Build tools with -Wl= ,-rpath,LIBDIR]) > AX_ARG_DEFAULT_DISABLE([githttp], [Download GIT repositories via HTTP]= ) > AX_ARG_DEFAULT_ENABLE([monitors], [Disable xenstat and xentop monitori= ng tools]) > AX_ARG_DEFAULT_ENABLE([ocamltools], [Disable Ocaml tools]) > -AX_ARG_DEFAULT_ENABLE([xsmpolicy], [Disable XSM policy compilation]) > +AX_ARG_DEFAULT_DISABLE([flask], [Enable building FLASK policy and tool= s for XSM]) > AX_ARG_DEFAULT_DISABLE([ovmf], [Enable OVMF]) > AX_ARG_DEFAULT_ENABLE([seabios], [Disable SeaBIOS]) > =20 > diff --git a/tools/flask/Makefile b/tools/flask/Makefile > index a31cc16..ad1ea7a 100644 > --- a/tools/flask/Makefile > +++ b/tools/flask/Makefile > @@ -1,8 +1,7 @@ > XEN_ROOT =3D $(CURDIR)/../.. > include $(XEN_ROOT)/tools/Rules.mk > =20 > -SUBDIRS-y :=3D utils > -SUBDIRS-$(FLASK_POLICY) +=3D policy > +SUBDIRS-y :=3D utils policy > =20 > .PHONY: all clean install distclean > all clean install distclean: %: subdirs-% >=20 Given the support of the maintainers and committers for the proposal [1], this patch should NOT be applied. [1] http://lists.xenproject.org/archives/html/xen-devel/2016-01/msg01796.html= --=20 Doug Goldstein --V4NAdrLBvMfBqXHPn8nfTDg1OSWNx4eIg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWmq4HXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvU4wcP/2Gz6/0GCHLYxKFFon+TvJ2r VWGJwqFRnrrJgcQ9MbYuieS8M5ufoxYzCqgOTzti9vonBYzZUFkNTQYE6oYWMdtO O4tKxASo9M699QSsG2yaIRQbc6HI++t/GaHjmc6FfH4dmSSOqxbqGtYslkVk3Rgs jzndLulZRjISMi90b5+o5BJVRLSSrmfJTou8DVpTSSHxsWFdB6YKbmkxkNdixDml vRyjcEqcqRJL+/u0suIYmyhfIlwiLAfBGYk6IqjTl5NqJmdXPgD/JmLVJPTGllhP +SUyZb1DnqfDLMmPYsqvHThOr2u/rAumM/F+AI2t35IbrnT+qD8jNRYZipY9FkHW g5nUtO0fMRERRH04+HQGIj2vSfxOCH8JvQgT11e69X0bHlVLq8QxIVpfqN4FB4dq N3pglkAhyPagNCn8NsfOFY9xM3/VMxICzMncBj632gmuEKJ3TN6yoY9yCdglixp3 l+hyQ7z5/FHP3xTzSKG9P6HSS0wTbUvlZKdDOq3XKm+Og9ZNOBkT5HFK3qc++vfb lpjrbYegXX1ujzmy7L9JGMW4tR7xFLmSjFJg0d7YEyTc26m6OHtbVqq5SMvg9F4u uZTPW+GVlzV6q84yF7dD7Bm+0gbW0JRdHxz00dqqCddWpSkg223eYfrrrO2kBDE5 OMOTRrtRZ5xaWyGuofn3 =xguc -----END PGP SIGNATURE----- --V4NAdrLBvMfBqXHPn8nfTDg1OSWNx4eIg-- --===============5621398898006444808== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5621398898006444808==--