From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/scripts: add size-stats-compare script
Date: Sat, 16 Jan 2016 22:18:11 +0100 [thread overview]
Message-ID: <569AB393.3010403@mind.be> (raw)
In-Reply-To: <20160116135112.52d70412@free-electrons.com>
On 16-01-16 13:51, Thomas Petazzoni wrote:
> Arnout,
>
> On Sat, 16 Jan 2016 01:28:23 +0100, Arnout Vandecappelle wrote:
>
>> I think you should also add a reference to the script to
>> docs/manual/common-usage.txt. No full documentation is needed, you can just
>> point to the --help option (otherwise it would just get out of sync).
>
> Agreed.
>
>
>>> +# This code relies on the output CSV files of 'make graph-size'. If you
>>> +# are comparing to an older Buildroot release, you can consider backporting
>>> +# that feature. See commits:
>>> +# 99aca138c20e1259ac8c23252c223e150d460482 (instrumentation hook)
>>> +# 598c80be8fc7b5ddfcba6f7715d90757033723ef (size-stats script)
>>> +# 24c75fbb38ffeb5c5a7278cf40f4f7cf867502e0 (make graph-size)
>>
>> I think this documentation should be part of the argparse description.
>
> I tend to disagree here, and instead who advocate to not have such
> documentation at all. Nowhere do we document which commits should be
> backported to bring this or that feature to an older Buildroot release,
> and I don't think we should start doing this.
OK, I actually meant that the documentation should be part of the description,
I tend to agree that it's not necessary to tell people what to backport.
Regards,
Arnout
>
> Best regards,
>
> Thomas
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-01-16 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 15:41 [Buildroot] [PATCH] support/scripts: add size-stats-compare script Thomas De Schampheleire
2016-01-16 0:28 ` Arnout Vandecappelle
2016-01-16 12:51 ` Thomas Petazzoni
2016-01-16 21:18 ` Arnout Vandecappelle [this message]
2016-01-19 12:51 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569AB393.3010403@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.