From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SteveD@redhat.com>
Subject: Re: [PATCH] nfsstat: show client rpc information correctly
To: Kinglong Mee <kinglongmee@gmail.com>
References: <567BE110.3070406@gmail.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        Benjamin Coddington <bcodding@redhat.com>
From: Steve Dickson <SteveD@redhat.com>
Message-ID: <569ABD7C.1000709@RedHat.com>
Date: Sat, 16 Jan 2016 17:00:28 -0500
MIME-Version: 1.0
In-Reply-To: <567BE110.3070406@gmail.com>
Content-Type: text/plain; charset=utf-8
List-ID: <linux-nfs.vger.kernel.org>



On 12/24/2015 07:12 AM, Kinglong Mee wrote:
> There are 59 client rpc procedures, not 60.
> 
> The order of rpc name must be the same as define of
> NFSPROC4_CLNT_xx in include/linux/nfs4.h,
> not nfs4_procedures in nfs4xdr.c.
> 
> Drop duplicate rpc name "getdevlist".
> 
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Committed! Thanks!

steved.

> ---
>  utils/nfsstat/nfsstat.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/utils/nfsstat/nfsstat.c b/utils/nfsstat/nfsstat.c
> index b67f0aa..8376347 100644
> --- a/utils/nfsstat/nfsstat.c
> +++ b/utils/nfsstat/nfsstat.c
> @@ -31,7 +31,7 @@ enum {
>  	SRVPROC3_SZ = 22,
>  	CLTPROC3_SZ = 22,
>  	SRVPROC4_SZ = 2,
> -	CLTPROC4_SZ = 60,
> +	CLTPROC4_SZ = 59,
>  	SRVPROC4OPS_SZ = 71,
>  };
>  
> @@ -135,11 +135,10 @@ static const char *	nfscltproc4name[CLTPROC4_SZ] = {
>  	"sequence",
>  	"get_lease_time",
>  	"reclaim_comp",
> -	"getdevinfo",
>  	"layoutget",
> +	"getdevinfo",
>  	"layoutcommit",
>  	"layoutreturn",
> -	"getdevlist",
>  	"secinfo_no",
>  	"test_stateid",
>  	"free_stateid",
>