From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKx75-00086g-8k for qemu-devel@nongnu.org; Sun, 17 Jan 2016 18:52:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aKx70-0007Zv-8B for qemu-devel@nongnu.org; Sun, 17 Jan 2016 18:52:03 -0500 Received: from mail-pa0-x242.google.com ([2607:f8b0:400e:c03::242]:34592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKx6z-0007Zp-VE for qemu-devel@nongnu.org; Sun, 17 Jan 2016 18:51:58 -0500 Received: by mail-pa0-x242.google.com with SMTP id yy13so31857390pab.1 for ; Sun, 17 Jan 2016 15:51:57 -0800 (PST) References: <1452906886-806-1-git-send-email-david@gibson.dropbear.id.au> From: Alexey Kardashevskiy Message-ID: <569C2917.9010908@ozlabs.ru> Date: Mon, 18 Jan 2016 10:51:51 +1100 MIME-Version: 1.0 In-Reply-To: <1452906886-806-1-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 0/3] Reduce abuse of rtas_st / rtas_ld List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, mdroth@linux.vnet.ibm.com, agraf@suse.de On 01/16/2016 12:14 PM, David Gibson wrote: > The rtas_ld() and rtas_st() helpers were designed for loading RTAS > arguments and storing RTAS returns which are in a simple, common array > format. > > However, a number of RTAS routines - and even non-RTAS routines - have > started using these for accessing other memory buffers, where the > normal qemu memory access routines would be more appropriate. > > This series removes some of these abuses of the RTAS accessors. imho simple renaming rtas_st to stl_be_phys_real (and so on for other rtas_xx) would make more sense as rtas_st&co do not have to do anything with RTAS itself, it is all about realmode guest memory access RTAS just happened to be the first client of it. btw in st_cc_buf(), what does "cc" stand for? -- Alexey