All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@ozlabs.org>
To: openbmc@lists.ozlabs.org, adamliyi@msn.com
Subject: Re: [PATCH docs] Add dbus method cold_reset() for bmc dbus object
Date: Mon, 18 Jan 2016 08:51:56 +0800	[thread overview]
Message-ID: <569C372C.7020605@ozlabs.org> (raw)
In-Reply-To: <1452868210-23453-2-git-send-email-openbmc-patches@stwcx.xyz>

Hi,

Thanks for your update to the docs repository, this is great to have.

A couple of points for general OpenBMC contributions though:

 - Can you use your real name as the author of this patch? If you
   set your git user.name config variable, your commits will
   have the correct info set:

      git config --global user.name "Your Name"

   Then, you can update this commit with:

      git commit --amend --author='Your Name <adamliyi@msn.com>'


 - We'll need a 'Signed-off-by:' line to indicate that your
   contributions are okay to include in the open-source projects
   used in OpenBMC. This will be something like:

     Signed-off-by: Your Name <adamliyi@msn.com>

   Same as above: you can add this to your existing commit
   using `git commit --amend`.

These are in the (new) contribution guidelines, up at:

  https://github.com/openbmc/docs/blob/master/contributing.md

Cheers,


Jeremy


On 15/01/16 22:30, OpenBMC Patches wrote:
> From: adamliyi <adamliyi@msn.com>
> 
> ---
>  dbus-interfaces.md | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/dbus-interfaces.md b/dbus-interfaces.md
> index 28fe410..7dee30f 100644
> --- a/dbus-interfaces.md
> +++ b/dbus-interfaces.md
> @@ -151,4 +151,11 @@ properties:
>  
>    *  `state`
>  
> +# BMC
> +
> +## `/org/openbmc/control/bmc/bmc0`
> +
> +methods:
> +
> +  *  `cold_reset()`
>  
> 

  reply	other threads:[~2016-01-18  0:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-15 14:30 [PATCH docs] Add dbus method cold_reset() for bmc dbus object OpenBMC Patches
2016-01-15 14:30 ` OpenBMC Patches
2016-01-18  0:51   ` Jeremy Kerr [this message]
2016-01-18  9:25     ` Yi TZ Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569C372C.7020605@ozlabs.org \
    --to=jk@ozlabs.org \
    --cc=adamliyi@msn.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.