From mboxrd@z Thu Jan  1 00:00:00 1970
From: Przemyslaw Marczak <p.marczak@samsung.com>
Date: Mon, 18 Jan 2016 09:16:14 +0100
Subject: [U-Boot] [PATCH] drivers/power/regulator/max77686.c: Don't use
 switch() on bools
In-Reply-To: <1452998677-30803-1-git-send-email-trini@konsulko.com>
References: <1452998677-30803-1-git-send-email-trini@konsulko.com>
Message-ID: <569C9F4E.2070209@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Tom,

On 01/17/2016 03:44 AM, Tom Rini wrote:
> With gcc-5.3 we get a warning for using switch() on a bool type.
> Rewrite these sections as if/else and update the one section that was
> using 1/0 instead of true/false.
>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Przemyslaw Marczak <p.marczak@samsung.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>   drivers/power/regulator/max77686.c | 28 ++++++++--------------------
>   1 file changed, 8 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/power/regulator/max77686.c b/drivers/power/regulator/max77686.c
> index 71678b6..7479af7 100644
> --- a/drivers/power/regulator/max77686.c
> +++ b/drivers/power/regulator/max77686.c
> @@ -515,25 +515,19 @@ static int max77686_ldo_enable(struct udevice *dev, int op, bool *enable)
>
>   		switch (on_off) {
>   		case OPMODE_OFF:
> -			*enable = 0;
> +			*enable = false;
>   			break;
>   		case OPMODE_ON:
> -			*enable = 1;
> +			*enable = true;
>   			break;
>   		default:
>   			return -EINVAL;
>   		}
>   	} else if (op == PMIC_OP_SET) {
> -		switch (*enable) {
> -		case 0:
> -			on_off = OPMODE_OFF;
> -			break;
> -		case 1:
> +		if (*enable)
>   			on_off = OPMODE_ON;
> -			break;
> -		default:
> -			return -EINVAL;
> -		}
> +		else
> +			on_off = OPMODE_OFF;
>
>   		ret = max77686_ldo_mode(dev, op, &on_off);
>   		if (ret)
> @@ -651,16 +645,10 @@ static int max77686_buck_enable(struct udevice *dev, int op, bool *enable)
>   			return -EINVAL;
>   		}
>   	} else if (op == PMIC_OP_SET) {
> -		switch (*enable) {
> -		case 0:
> -			on_off = OPMODE_OFF;
> -			break;
> -		case 1:
> +		if (*enable)
>   			on_off = OPMODE_ON;
> -			break;
> -		default:
> -			return -EINVAL;
> -		}
> +		else
> +			on_off = OPMODE_OFF;
>
>   		ret = max77686_buck_mode(dev, op, &on_off);
>   		if (ret)
>

Thank you for pointing that:)

Acked-by: Przemyslaw Marczak <p.marczak@samsung.com>

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com