From: chenfeng <puck.chen@hisilicon.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lee.jones@linaro.org>, <linux-kernel@vger.kernel.org>,
<lgirdwood@gmail.com>, <yudongbin@hisilicon.com>,
<saberlily.xia@hisilicon.com>, <suzhuangluan@hisilicon.com>,
<kong.kongxinwei@hisilicon.com>, <xuyiping@hisilicon.com>,
<z.liuxinliang@hisilicon.com>, <puck.chenfeng@gmail.com>,
<weidong2@hisilicon.com>, <w.f@huawei.com>,
<qijiwen@hisilicon.com>, <peter.panshilin@hisilicon.com>,
<dan.zhao@hisilicon.com>, <linuxarm@huawei.com>,
<liguozhu@hisilicon.com>
Subject: Re: [PATCH v5 4/5] regulator: add regulator driver of hi655x pmic
Date: Mon, 18 Jan 2016 16:26:45 +0800 [thread overview]
Message-ID: <569CA1C5.3020005@hisilicon.com> (raw)
In-Reply-To: <20160115180740.GD6588@sirena.org.uk>
On 2016/1/16 2:07, Mark Brown wrote:
> On Tue, Jan 12, 2016 at 10:18:03AM +0800, chenfeng wrote:
>> On 2016/1/12 2:24, Mark Brown wrote:
>>> On Mon, Jan 11, 2016 at 08:20:16PM +0800, Chen Feng wrote:
>
>>>> +config REGULATOR_HI655X
>>>> + tristate "Hisilicon HI655X PMIC regulators support"
>>>> + depends on ARCH_HISI || (COMPILE_TEST && ARM64)
>
>>> Why does this depend on ARM64? If it's needed it probably indicates a
>>> problem...
>
>> There will be compile warning with arch parisc.
>
>> Add the current support platform is ARM64.
>
> The whole point of COMPILE_TEST is to allow people who are working
> generally rather than with the particular hardware to build things to
> improve build test coverage when doing general kernel work. A warning
> on a very obscure architecture is really not a blocker here.
>
ok, I will remove the ARM64 depends.
>> I am not sure about open coding regulators_node.
>
>> I take max8907-regulator.c for reference. The code there is:
>> 224 static int max8907_regulator_parse_dt(struct platform_device *pdev)
>
> The existance of older drivers that have not yet been converted to use
> newer core subsystem features is not a good reason to avoid using those
> core subsystem features. You'll commonly find this situation in the
> kernel.
>
>> Can you give me some references? Really thanks for your help.
>
> $ grep -l regulators_node drivers/regulator/*.c
> drivers/regulator/88pm800.c
> drivers/regulator/axp20x-regulator.c
> drivers/regulator/da9062-regulator.c
> drivers/regulator/isl9305.c
> drivers/regulator/max14577.c
> drivers/regulator/max77686.c
> drivers/regulator/max77693.c
> drivers/regulator/max77802.c
> drivers/regulator/mt6311-regulator.c
> drivers/regulator/of_regulator.c
> drivers/regulator/pv88060-regulator.c
> drivers/regulator/pv88090-regulator.c
> drivers/regulator/rn5t618-regulator.c
> drivers/regulator/rt5033-regulator.c
> drivers/regulator/sky81452-regulator.c
> drivers/regulator/tps65023-regulator.c
> drivers/regulator/tps65086-regulator.c
> drivers/regulator/tps65217-regulator.c
>
Understand, I will remove the match-table and add the regulators_node
to match the regulator-compatible in dts.
next prev parent reply other threads:[~2016-01-18 8:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 12:20 [PATCH v5 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core Chen Feng
2016-01-11 12:20 ` [PATCH v5 1/5] doc: bindings: Add document for mfd hi665x PMIC Chen Feng
2016-01-25 12:53 ` Lee Jones
2016-01-26 6:26 ` chenfeng
2016-01-11 12:20 ` [PATCH v5 2/5] doc: bindings: Document for hi655x regulator driver Chen Feng
2016-01-11 18:17 ` Mark Brown
2016-01-12 2:07 ` chenfeng
2016-01-11 12:20 ` [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver Chen Feng
2016-01-25 14:22 ` Lee Jones
2016-01-26 6:32 ` chenfeng
2016-01-28 9:48 ` chenfeng
2016-01-28 11:30 ` Lee Jones
2016-01-11 12:20 ` [PATCH v5 4/5] regulator: add regulator driver of hi655x pmic Chen Feng
2016-01-11 18:24 ` Mark Brown
2016-01-12 2:18 ` chenfeng
2016-01-15 18:07 ` Mark Brown
2016-01-18 8:26 ` chenfeng [this message]
2016-01-11 12:20 ` [PATCH v5 5/5] hisilicon/dts: Add hi655x pmic dts node Chen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569CA1C5.3020005@hisilicon.com \
--to=puck.chen@hisilicon.com \
--cc=broonie@kernel.org \
--cc=dan.zhao@hisilicon.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=peter.panshilin@hisilicon.com \
--cc=puck.chenfeng@gmail.com \
--cc=qijiwen@hisilicon.com \
--cc=saberlily.xia@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=w.f@huawei.com \
--cc=weidong2@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=yudongbin@hisilicon.com \
--cc=z.liuxinliang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.