Re: Compiling for FreeBSD, Bluestore requires AIO

[Willem Jan Withagen <wjw@digiware.nl>]

On 18-1-2016 10:54, Mykola Golub wrote:
> On Fri, Jan 15, 2016 at 07:34:29PM +0100, Willem Jan Withagen wrote:
> 
>> ATM I've excluded the building of Bluestore, not really knowing how hard
>> that is going to bite me in run the tests.
> 
> It looks like you have figured out how to exclude building Bluestore,
> but just in case, I have the following PR open, that do the same:
> 
> https://github.com/ceph/ceph/pull/7169
> 

I'd say: lgtm.... :)

The one thing to debate is to not make it depend on HAVE_LIBAIO, but
make it depend on a new configflag: WITH_BLUESTORE.

That even allows to include LIBAIO for the old stuff, and still run
without BlueStore.

And I patched configure.ac for that:
194,201d193
< # bluestore?
< AC_ARG_WITH([bluestore],
<       [AS_HELP_STRING([--with-bluestore], [build bluestore files])],
<       [],
<       [with_bluestore=yes])
< AM_CONDITIONAL(WITH_BLUESTORE, test "$with_bluestore" = "yes")
< #AS_IF([test "$with_bluestore" = "yes"],[AC_DEFINE([WITH_BLUESTORE])])
<


--WjW