From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v12 0/18] Add Analogix Core Display Port Driver Date: Mon, 18 Jan 2016 18:48:38 +0800 Message-ID: <569CC306.8030207@rock-chips.com> References: <1450873538-18304-1-git-send-email-ykk@rock-chips.com> <2322926.s1viZ6tSS3@phil> <1670568.VBNHbJuGkf@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1670568.VBNHbJuGkf@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Heiko Stuebner Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Russell King , linux-rockchip@lists.infradead.org, Jingoo Han , emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kishon Vijay Abraham I , javier@osg.samsung.com, Rob Herring , Andy Yan , Thierry Reding , Gustavo Padovan , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgSGVpa28sCgpTb3JyeSBmb3IgdGhlIGRlbGF5IHJlcGx5IDspCgpPbiAwMS8xNy8yMDE2IDEw OjI1IFBNLCBIZWlrbyBTdHVlYm5lciB3cm90ZToKPiBIaSBZYWtpciwKPgo+IEFtIE1pdHR3b2No LCAxMy4gSmFudWFyIDIwMTYsIDE1OjU5OjUxIHNjaHJpZWIgSGVpa28gU3R1ZWJuZXI6Cj4+IEFt IE1pdHR3b2NoLCAyMy4gRGV6ZW1iZXIgMjAxNSwgMjA6MjU6Mzggc2NocmllYiBZYWtpciBZYW5n Ogo+Pj4gICAgIFRoZSBTYW1zdW5nIEV4eW5vcyBlRFAgY29udHJvbGxlciBhbmQgUm9ja2NoaXAg UkszMjg4IGVEUCBjb250cm9sbGVyCj4+Pgo+Pj4gc2hhcmUgdGhlIHNhbWUgSVAsIHNvIGEgbG90 IG9mIHBhcnRzIGNhbiBiZSByZS11c2VkLiBJIHNwbGl0IHRoZSBjb21tb24KPj4+IGNvZGUgaW50 byBicmlkZ2UgZGlyZWN0b3J5LCB0aGVuIHJrMzI4OCBhbmQgZXh5bm9zIG9ubHkgbmVlZCB0byBr ZWVwCj4+PiBzb21lIHBsYXRmb3JtIGNvZGUuIENhdXNlIEkgY2FuJ3QgZmluZCB0aGUgZXhhY3Qg SVAgbmFtZSBvZiBleHlub3MgZHAKPj4+IGNvbnRyb2xsZXIsIHNvIEkgZGVjaWRlIHRvIG5hbWUg ZHAgY29yZSBkcml2ZXIgd2l0aCAiYW5hbG9naXgiIHdoaWNoIEkKPj4+IGZpbmQgaW4gcmszMjg4 IGVEUCBUUk0KPj4gY291bGQgeW91IHJlYmFzZSB5b3VyIHBhdGNoZXMgb24gdG9wIG9mIERhdmUn cyBkcm0tbmV4dCBicmFuY2ggWzBdIHBsZWFzZT8KPj4gVGhlIGV4eW5vcyBwYXJ0IGdvdCBzb21l IGNvbnN0IGF0dHJpYnV0ZXMgZm9yIHRoZSAqX2Z1bmNfb3BzIHN0cnVjdHMgYW5kCj4+IGRybV9l bmNvZGVyX2luaXQgZ290IGFuIGFkZGl0aW9uYWwgcGFyYW1ldGVyLgpTdXJlCj4+IEknbSBzdGls bCBob3BpbmcgdGhhdCB3ZSBjYW4gZ2V0IHRoaXMgZmluYWxseSBjb21taXR0ZWQgb25jZSA0LjUt cmMxIGlzCj4+IHJlbGVhc2VkIGluIDEuNSB3ZWVrcyA6LSkgLgo+Pgo+PiBJIGRpZCB0cnkgdG8g bWVyZ2UgdGhpbmdzIHRvZ2V0aGVyIFsxXSwgdGhlIHN5c3RlbSBhdCBsZWFzdCBjb21lcyB1cCBh bmQKPj4gZGV0ZWN0cyB0aGUgcGFuZWwgKEVESUQgaXMgcmVhZCBjb3JyZWN0bHkgYW5kIGl0IHR1 cm5zIHRoZSBiYWNrbGlnaHQgb24pCj4+IGJ1dCBJIGRvbid0IHNlZSBhbnkgb3V0cHV0IG9uIHRo ZSBkaXNwbGF5IC0gaGRtaSB3b3JrcyBmaW5lIHRob3VnaCBhbmQKPj4gWDExIGlzIGNsYWltaW5n IGV2ZXJ5dGhpbmcgdG8gYmUgZmluZSBpbiBib3RoIGNhc2VzLgpIbW1tLi4uLiBJIHdvdWxkIGRv dWJsZSBjaGVjayBpbiBteSBzaWRlLgo+PiBTbyBJIGRvbid0IGtub3cgeWV0IGlmIEkgbWFkZSBh IG1pc3Rha2Ugd2hlbiBwdXR0aW5nIHRoaXMgdG9nZXRoZXIgb3IKPj4gdGhlcmUgaXMgYW4gaXNz dWUgb24gdGhlIGRyaXZlci1zaWRlLgo+IEkgd2FzIGFibGUgdG8gZGVidWcgdGhpcyBhIGJpdCBt b3JlLCBhbmQgaXQgc2VlbXMgdGhlIGVuY29kZXJfaGVscGVyX2Z1bmNzCj4gZG9uJ3QgbGlrZSB0 aGUgcHJlcGFyZS9jb21taXQgY2FsbGJhY2tzIGFuZCBsaWtlIGVuYWJsZSBiZXR0ZXIuCkFoLi4u Li4gWWVwLCBBdG9taWMgaGVscGVyIHNlZW1zIHdvdWxkbid0IGNhbGwgdGhlIHByZXBhZXIvY29t bWl0LCAKaW5zdGVhZCB3ZSBjYW4gdXNlIHRoZSBlbmJhbGUvZGlzYWJsZSBoZWxwZXIgZnVuY3Rp b25zLgo+IFNvIHdoZW4gSSBkbyBzb21ldGhpbmcgc2ltaWxhciB0byBNYXJrcyBwYXRjaCBhOGVl ZjcxZDM4ZGEgKCJkcm0vcm9ja2NoaXA6Cj4gZHdfaGRtaTogdXNlIGVuY29kZXIgZW5hYmxlIGZ1 bmN0aW9uIiksIGxpa2UgaW4gdGhlIGF0dGFjaGVkIHBhdGNoICh0byBiZQo+IGZvbGRlZCBpbnRv IHRoZSBvcmlnaW5hbCBhZGRpdGlvbiBvZiB0aG9zZSBmdW5jdGlvbnMpLCBJIGdldCBkaXNwbGF5 IG91dHB1dAo+IGFnYWluLgoKVGhhbmtzIGZvciB5b3VyIHBhdGllbnQgZGVidWcsIEkgd291bGQg c2VuZCB0aGUgbmV3IHZlcnNpb24gb3V0IHNvb24gIDspCgotIFlha2lyCj4KPiBIZWlrbwo+Cj4+ IFswXSBodHRwOi8vY2dpdC5mcmVlZGVza3RvcC5vcmcvfmFpcmxpZWQvbGludXgvbG9nLz9oPWRy bS1uZXh0Cj4+IFsxXSBodHRwczovL2dpdGh1Yi5jb20vbW1pbmQvbGludXgtcm9ja2NoaXAvdHJl ZS90bXAvYW5hbG9naXhkcF92MTItdmV5cm9uCj4+IEkgbGVmdCBvdXQgcGF0Y2gxNiwgcGVyIHlv dXIgdGFsayB3aXRoIEppbmdvbyBhbmQgbWUgbm90IHNlZWluZyBhbnkgQVVYCj4+IENIIGVycm9y cyB3aXRob3V0IGl0LgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Mon, 18 Jan 2016 18:48:38 +0800 Subject: [PATCH v12 0/18] Add Analogix Core Display Port Driver In-Reply-To: <1670568.VBNHbJuGkf@phil> References: <1450873538-18304-1-git-send-email-ykk@rock-chips.com> <2322926.s1viZ6tSS3@phil> <1670568.VBNHbJuGkf@phil> Message-ID: <569CC306.8030207@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Heiko, Sorry for the delay reply ;) On 01/17/2016 10:25 PM, Heiko Stuebner wrote: > Hi Yakir, > > Am Mittwoch, 13. Januar 2016, 15:59:51 schrieb Heiko Stuebner: >> Am Mittwoch, 23. Dezember 2015, 20:25:38 schrieb Yakir Yang: >>> The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller >>> >>> share the same IP, so a lot of parts can be re-used. I split the common >>> code into bridge directory, then rk3288 and exynos only need to keep >>> some platform code. Cause I can't find the exact IP name of exynos dp >>> controller, so I decide to name dp core driver with "analogix" which I >>> find in rk3288 eDP TRM >> could you rebase your patches on top of Dave's drm-next branch [0] please? >> The exynos part got some const attributes for the *_func_ops structs and >> drm_encoder_init got an additional parameter. Sure >> I'm still hoping that we can get this finally committed once 4.5-rc1 is >> released in 1.5 weeks :-) . >> >> I did try to merge things together [1], the system at least comes up and >> detects the panel (EDID is read correctly and it turns the backlight on) >> but I don't see any output on the display - hdmi works fine though and >> X11 is claiming everything to be fine in both cases. Hmmm.... I would double check in my side. >> So I don't know yet if I made a mistake when putting this together or >> there is an issue on the driver-side. > I was able to debug this a bit more, and it seems the encoder_helper_funcs > don't like the prepare/commit callbacks and like enable better. Ah..... Yep, Atomic helper seems wouldn't call the prepaer/commit, instead we can use the enbale/disable helper functions. > So when I do something similar to Marks patch a8eef71d38da ("drm/rockchip: > dw_hdmi: use encoder enable function"), like in the attached patch (to be > folded into the original addition of those functions), I get display output > again. Thanks for your patient debug, I would send the new version out soon ;) - Yakir > > Heiko > >> [0] http://cgit.freedesktop.org/~airlied/linux/log/?h=drm-next >> [1] https://github.com/mmind/linux-rockchip/tree/tmp/analogixdp_v12-veyron >> I left out patch16, per your talk with Jingoo and me not seeing any AUX >> CH errors without it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754621AbcARKsr (ORCPT ); Mon, 18 Jan 2016 05:48:47 -0500 Received: from lucky1.263xmail.com ([211.157.147.130]:38119 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754202AbcARKsp (ORCPT ); Mon, 18 Jan 2016 05:48:45 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v12 0/18] Add Analogix Core Display Port Driver To: Heiko Stuebner References: <1450873538-18304-1-git-send-email-ykk@rock-chips.com> <2322926.s1viZ6tSS3@phil> <1670568.VBNHbJuGkf@phil> Cc: Inki Dae , Mark Yao , Jingoo Han , Thierry Reding , Krzysztof Kozlowski , Rob Herring , Russell King , emil.l.velikov@gmail.com, Gustavo Padovan , Kishon Vijay Abraham I , javier@osg.samsung.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <569CC306.8030207@rock-chips.com> Date: Mon, 18 Jan 2016 18:48:38 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1670568.VBNHbJuGkf@phil> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, Sorry for the delay reply ;) On 01/17/2016 10:25 PM, Heiko Stuebner wrote: > Hi Yakir, > > Am Mittwoch, 13. Januar 2016, 15:59:51 schrieb Heiko Stuebner: >> Am Mittwoch, 23. Dezember 2015, 20:25:38 schrieb Yakir Yang: >>> The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller >>> >>> share the same IP, so a lot of parts can be re-used. I split the common >>> code into bridge directory, then rk3288 and exynos only need to keep >>> some platform code. Cause I can't find the exact IP name of exynos dp >>> controller, so I decide to name dp core driver with "analogix" which I >>> find in rk3288 eDP TRM >> could you rebase your patches on top of Dave's drm-next branch [0] please? >> The exynos part got some const attributes for the *_func_ops structs and >> drm_encoder_init got an additional parameter. Sure >> I'm still hoping that we can get this finally committed once 4.5-rc1 is >> released in 1.5 weeks :-) . >> >> I did try to merge things together [1], the system at least comes up and >> detects the panel (EDID is read correctly and it turns the backlight on) >> but I don't see any output on the display - hdmi works fine though and >> X11 is claiming everything to be fine in both cases. Hmmm.... I would double check in my side. >> So I don't know yet if I made a mistake when putting this together or >> there is an issue on the driver-side. > I was able to debug this a bit more, and it seems the encoder_helper_funcs > don't like the prepare/commit callbacks and like enable better. Ah..... Yep, Atomic helper seems wouldn't call the prepaer/commit, instead we can use the enbale/disable helper functions. > So when I do something similar to Marks patch a8eef71d38da ("drm/rockchip: > dw_hdmi: use encoder enable function"), like in the attached patch (to be > folded into the original addition of those functions), I get display output > again. Thanks for your patient debug, I would send the new version out soon ;) - Yakir > > Heiko > >> [0] http://cgit.freedesktop.org/~airlied/linux/log/?h=drm-next >> [1] https://github.com/mmind/linux-rockchip/tree/tmp/analogixdp_v12-veyron >> I left out patch16, per your talk with Jingoo and me not seeing any AUX >> CH errors without it.