From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 3/9] drm/i915: Remove intel_crtc->atomic.disable_ips.
Date: Mon, 18 Jan 2016 13:10:41 +0100 [thread overview]
Message-ID: <569CD641.7030702@linux.intel.com> (raw)
In-Reply-To: <20160113130203.GG23290@intel.com>
Op 13-01-16 om 14:02 schreef Ville Syrjälä:
> On Mon, Jan 11, 2016 at 01:27:43PM +0100, Maarten Lankhorst wrote:
>> This is a revert of commit 066cf55b9ce3 "drm/i915: Fix IPS related flicker".
>> intel_pre_disable_primary already handles this, and now everything
>> goes through the atomic path there's no need to try to disable ips twice.
> If it's a revert why wasn't it done with 'git revert'?
A straight revert would fail to apply.
> Also I'm not sure it isn't a step backwards. Based on the spec we should
> be able to keep IPS enabled as long as one plane (possibly referring to
> either primary or sprite) is enabled on the pipe. So in theory we should
> keep the IPS handling out of the primary plane code, and instead we
> should compute the IPS state based on the set of active planes on the
> pipe.
You're probably right. But pre_disable_primary has the following warning:
* FIXME IPS should be fine as long as one plane is
* enabled, but in practice it seems to have problems
* when going from primary only to sprite only and vice
* versa.
Hence I'm not doing anything to support that. Even if I did it should be a separate commit.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-18 12:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 12:27 [PATCH v2 0/9] Kill off intel_crtc->atomic! Maarten Lankhorst
2016-01-11 12:27 ` [PATCH v2 1/9] drm/i915: Unify power domain handling Maarten Lankhorst
2016-01-11 12:43 ` Maarten Lankhorst
2016-01-11 13:31 ` [PATCH v2 0.999/9] drm/i915: Pass crtc state to modeset_get_crtc_power_domains Maarten Lankhorst
2016-01-11 12:27 ` [PATCH v2 2/9] drm/i915: Kill off intel_crtc->atomic.wait_vblank, v3 Maarten Lankhorst
2016-01-13 12:58 ` Ville Syrjälä
2016-02-09 10:27 ` Maarten Lankhorst
2016-02-09 10:42 ` Ville Syrjälä
2016-02-09 11:07 ` Maarten Lankhorst
2016-02-09 11:22 ` Ville Syrjälä
2016-01-11 12:27 ` [PATCH v2 3/9] drm/i915: Remove intel_crtc->atomic.disable_ips Maarten Lankhorst
2016-01-13 13:02 ` Ville Syrjälä
2016-01-18 12:10 ` Maarten Lankhorst [this message]
2016-01-18 13:27 ` Daniel Stone
2016-01-11 12:27 ` [PATCH v2 4/9] drm/i915: Remove atomic.pre_disable_primary Maarten Lankhorst
2016-01-11 12:27 ` [PATCH v2 5/9] drm/i915: Remove update_sprite_watermarks Maarten Lankhorst
2016-01-11 12:27 ` [PATCH v2 6/9] drm/i915: Remove some post-commit members from intel_crtc->atomic, v2 Maarten Lankhorst
2016-01-11 12:27 ` [PATCH v2 7/9] drm/i915: Nuke fbc " Maarten Lankhorst
2016-01-11 12:27 ` [PATCH v2 8/9] drm/i915: Do not compute watermarks on a noop Maarten Lankhorst
2016-01-11 12:27 ` [PATCH v2 9/9] drm/i915: Remove vblank wait from hsw_enable_ips Maarten Lankhorst
2016-01-11 12:49 ` ✗ failure: Fi.CI.BAT Patchwork
2016-01-11 14:30 ` Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569CD641.7030702@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.