From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Anders Roxell <anders.roxell@linaro.org>, <bigeasy@linutronix.de>
Cc: <linux-rt-users@vger.kernel.org>, <khilman@kernel.org>
Subject: Re: [PATCH 9/9] driver/gpio: gpio-omap: fix incompatible pointer type
Date: Mon, 18 Jan 2016 16:29:21 +0200 [thread overview]
Message-ID: <569CF6C1.5010106@ti.com> (raw)
In-Reply-To: <1452885673-30891-10-git-send-email-anders.roxell@linaro.org>
On 01/15/2016 09:21 PM, Anders Roxell wrote:
> Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
> warning without this fix:
> ../drivers/gpio/gpio-omap.c: In function 'omap_gpio_runtime_resume':
> ../drivers/gpio/gpio-omap.c:1398:4: warning: passing argument 1 of
> 'rt_spin_unlock' from incompatible pointer type [enabled by default]
> In file included from ../include/linux/spinlock.h:290:0,
> from ../include/linux/seqlock.h:35,
> from ../include/linux/time.h:5,
> from ../include/linux/stat.h:18,
> from ../include/linux/module.h:10,
> from ../drivers/gpio/gpio-omap.c:16:
> ../include/linux/spinlock_rt.h:24:56: note: expected
> 'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *'
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> drivers/gpio/gpio-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index 004888b..f3028e7 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1395,7 +1395,7 @@ static int omap_gpio_runtime_resume(struct device *dev)
> if (c != bank->context_loss_count) {
> omap_gpio_restore_context(bank);
> } else {
> - spin_unlock_irqrestore(&bank->lock, flags);
> + raw_spin_unlock_irqrestore(&bank->lock, flags);
> return 0;
> }
> }
>
This patch is not required since I've asked Sebastian to revert patch
caused this warning.
--
regards,
-grygorii
next prev parent reply other threads:[~2016-01-18 14:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 19:21 [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Anders Roxell
2016-01-15 19:21 ` [PATCH 1/9] drivers/clocksource: timer-atmel-pit: fix irq name Anders Roxell
2016-01-15 19:21 ` [PATCH 2/9] drivers/clocksource: timer-atmel-pit: fix forward declaration Anders Roxell
2016-01-15 19:21 ` [PATCH 3/9] drivers/clocksource: timer-atmel-pit: fix unused var 'ret' Anders Roxell
2016-01-15 19:21 ` [PATCH 4/9] drivers/clocksource: timer-atmel-st: undeclared " Anders Roxell
2016-01-15 19:21 ` [PATCH 5/9] drivers/clocksource: timer-atmel-st: fix unused " Anders Roxell
[not found] ` <CAGt3f4kZAL65+yeNh1qrAbap4SJNwQrSa=5QF0LN9Mh8ew5HSQ@mail.gmail.com>
2016-01-18 18:34 ` Brian Silverman
2016-01-20 21:33 ` Anders Roxell
2016-01-20 21:34 ` Anders Roxell
2016-01-21 8:14 ` Sebastian Andrzej Siewior
2016-01-15 19:21 ` [PATCH 6/9] drivers/clocksource: timer-atmel-st: undeclared var 'irq' Anders Roxell
2016-01-15 19:21 ` [PATCH 7/9] kernel/time: hrtimer: fix forward declaration Anders Roxell
2016-01-15 19:21 ` [PATCH 8/9] drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock Anders Roxell
2016-01-18 17:02 ` Sebastian Andrzej Siewior
2016-01-20 21:28 ` Anders Roxell
2016-01-15 19:21 ` [PATCH 9/9] driver/gpio: gpio-omap: fix incompatible pointer type Anders Roxell
2016-01-18 14:29 ` Grygorii Strashko [this message]
2016-01-20 21:29 ` Anders Roxell
2016-01-18 17:54 ` [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569CF6C1.5010106@ti.com \
--to=grygorii.strashko@ti.com \
--cc=anders.roxell@linaro.org \
--cc=bigeasy@linutronix.de \
--cc=khilman@kernel.org \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.