From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd) Date: Mon, 18 Jan 2016 17:42:24 +0000 Message-ID: <569D2400.9030702@imgtec.com> References: <20160118172025.GM19130@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by gabe.freedesktop.org (Postfix) with ESMTP id A0B676E61D for ; Mon, 18 Jan 2016 09:42:23 -0800 (PST) In-Reply-To: <20160118172025.GM19130@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: daniel@ffwll.ch Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, julia.lawall@lip6.fr, kbuild-all@01.org, daniel.vetter@intel.com List-Id: dri-devel@lists.freedesktop.org SSBleHBlY3QgdGhpcyBpcyB0aGUgc2NyaXB0IHNoZSBtZW50aW9uczoKaHR0cHM6Ly9naXRodWIu Y29tL2NvY2NpbmVsbGUvY29jY2luZWxsZXJ5L2Jsb2IvbWFzdGVyL2l0bnVsbC9pdG51bGwuY29j Y2kKCkp1bGlhIGlzIG9uZSBvZiB0aGUgYXV0aG9ycyBvZiBDb2NjaW5lbGxlLCBhbmQgdGhlIGF1 dGhvciBvZiB0aGF0IHNjcmlwdCA6KQoKCk9uIDE4LzAxLzE2IDE3OjIwLCBEYW5pZWwgVmV0dGVy IHdyb3RlOgo+IE9uIE1vbiwgSmFuIDE4LCAyMDE2IGF0IDA0OjQ5OjA2UE0gKzAxMDAsIEp1bGlh IExhd2FsbCB3cm90ZToKPj4gTGlzdF9mb3JfZWFjaCBlbnRyeSBiaW5kcyBpdHMgZmlyc3QgYXJn dW1lbnQgdG8gYW4gb2Zmc2V0IGZyb20gdGhlIGxpc3QKPj4gcG9pbnRlciwgc28gdGhpcyBzaG91 bGQgbm90IGJlIE5VTEwuCj4+Cj4+IEdlbmVyYXRlZCBieTogc2NyaXB0cy9jb2NjaW5lbGxlL2l0 ZXJhdG9ycy9pdG51bGwuY29jY2kKPj4KPj4gU2lnbmVkLW9mZi1ieTogRmVuZ2d1YW5nIFd1IDxm ZW5nZ3Vhbmcud3VAaW50ZWwuY29tPgo+PiAtLS0KPj4KPj4gUGxlYXNlIHRha2UgdGhlIHBhdGNo IG9ubHkgaWYgaXQncyBhIHBvc2l0aXZlIHdhcm5pbmcuIFRoYW5rcyEKPiAKPiBBZ2FpbnN0IHdo aWNoIHRyZWUgaXMgdGhpcz8gSSBjYW4ndCBmaW5kIHRoaXMgYW55d2hlcmUgbGlrZSB0aGF0IC4u Lgo+IC1EYW5pZWwKPiAKPj4KPj4gIGludGVsX2Rpc3BsYXkuYyB8ICAgIDIgKy0KPj4gIDEgZmls ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+Pgo+PiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+IEBAIC0xNjQ5OCw3ICsxNjQ5OCw3IEBAIHZvaWQgaW50 ZWxfbW9kZXNldF9wcmVjbG9zZShzdHJ1Y3QgZHJtX2QKPj4gIAkJc3RydWN0IGludGVsX2ZsaXBf d29yayAqd29yazsKPj4KPj4gIAkJbGlzdF9mb3JfZWFjaF9lbnRyeSh3b3JrLCAmY3J0Yy0+Zmxp cF93b3JrLCBoZWFkKSB7Cj4+IC0JCQlpZiAod29yayAmJiB3b3JrLT5ldmVudCAmJgo+PiArCQkJ aWYgKHdvcmstPmV2ZW50ICYmCj4+ICAJCQkgICAgd29yay0+ZXZlbnQtPmJhc2UuZmlsZV9wcml2 ID09IGZpbGUpIHsKPj4gIAkJCQlrZnJlZSh3b3JrLT5ldmVudCk7Cj4+ICAJCQkJd29yay0+ZXZl bnQgPSBOVUxMOwo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwo+PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKPj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932269AbcARRms (ORCPT ); Mon, 18 Jan 2016 12:42:48 -0500 Received: from [195.59.15.196] ([195.59.15.196]:61128 "EHLO mailapp01.imgtec.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S932216AbcARRmo (ORCPT ); Mon, 18 Jan 2016 12:42:44 -0500 Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd) References: <20160118172025.GM19130@phenom.ffwll.local> From: Eric Engestrom CC: , , , , , To: Message-ID: <569D2400.9030702@imgtec.com> Date: Mon, 18 Jan 2016 17:42:24 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160118172025.GM19130@phenom.ffwll.local> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.60.4.28] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I expect this is the script she mentions: https://github.com/coccinelle/coccinellery/blob/master/itnull/itnull.cocci Julia is one of the authors of Coccinelle, and the author of that script :) On 18/01/16 17:20, Daniel Vetter wrote: > On Mon, Jan 18, 2016 at 04:49:06PM +0100, Julia Lawall wrote: >> List_for_each entry binds its first argument to an offset from the list >> pointer, so this should not be NULL. >> >> Generated by: scripts/coccinelle/iterators/itnull.cocci >> >> Signed-off-by: Fengguang Wu >> --- >> >> Please take the patch only if it's a positive warning. Thanks! > > Against which tree is this? I can't find this anywhere like that ... > -Daniel > >> >> intel_display.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- a/drivers/gpu/drm/i915/intel_display.c >> +++ b/drivers/gpu/drm/i915/intel_display.c >> @@ -16498,7 +16498,7 @@ void intel_modeset_preclose(struct drm_d >> struct intel_flip_work *work; >> >> list_for_each_entry(work, &crtc->flip_work, head) { >> - if (work && work->event && >> + if (work->event && >> work->event->base.file_priv == file) { >> kfree(work->event); >> work->event = NULL; >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx >