Re: [Qemu-devel] [PATCH] sysbus: Remove ignored return value of FindSysbusDeviceFunc

["Andreas Färber" <afaerber@suse.de>]

Am 18.01.2016 um 05:39 schrieb David Gibson:
> Functions of type FindSysbusDeviceFunc currently return an integer.  I
> recently made an error in a patch because I assumed that this return value
> would control whether iteration of the function across devices continues
> or not.  In fact, the function's return value is always ignored.
> 
> This changes the function type to return void, so that others don't make
> the same mistake.

Have you considered implementing the behavior you expected? :)
Not necessary for your use case or too complicated?

> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> 
> Please apply.

Patch looks okay, too short notice for today's pull though.
Usually we avoid "I" in a commit message.

Regards,
Andreas

> 
>  hw/arm/sysbus-fdt.c    | 4 ++--
>  hw/core/machine.c      | 2 +-
>  hw/core/platform-bus.c | 8 ++------
>  hw/ppc/e500.c          | 4 +---
>  hw/ppc/spapr.c         | 4 +---
>  include/hw/sysbus.h    | 2 +-
>  6 files changed, 8 insertions(+), 16 deletions(-)

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)