From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] xen: Improvements to clean and distclean targets Date: Mon, 18 Jan 2016 18:19:11 +0000 Message-ID: <569D2C9F.9070404@citrix.com> References: <1453134445-31356-1-git-send-email-andrew.cooper3@citrix.com> <569D23E102000078000C825D@prv-mh.provo.novell.com> <569D1692.5070709@citrix.com> <569D27A602000078000C82B6@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <569D27A602000078000C82B6@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Xen-devel List-Id: xen-devel@lists.xenproject.org On 18/01/16 16:57, Jan Beulich wrote: >>>> On 18.01.16 at 17:45, wrote: >> On 18/01/16 16:41, Jan Beulich wrote: >>>>>> On 18.01.16 at 17:27, wrote: >>>> * Move '*~' and 'core' into the find rule. >>> I don't understand this part: Where in the build process do such get >>> generated? I'm tempted to instead recommend to just drop those >>> from the rm invocation... >> No idea about 'core' files, but *~ are emacs backup files. > But emacs should clean up after itself; this shouldn't be the job > of our clean rule. Why? the point is to have a one-revision old version of the file to hand. > >> Most clean rules do "rm *.o *.d *~ core" in the local directory, but >> there are some directories in the the public header area which don't get >> recursed into, and therefore missed. > Well - the same holds here than: I'd rather remove those than > extend the bogus use. Bogus is a matter of opinion, and there are a lot of emacs users (myself included) who will disagree with you here. ~Andrew