From mboxrd@z Thu Jan 1 00:00:00 1970 From: f.fainelli@gmail.com (Florian Fainelli) Date: Mon, 18 Jan 2016 11:07:06 -0800 Subject: [PATCH] ARM: debug-ll: fix BCM63xx entry for multiplatform In-Reply-To: <5641204.G6RtGs3Kji@wuerfel> References: <5641204.G6RtGs3Kji@wuerfel> Message-ID: <569D37DA.7090309@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 18/01/2016 01:51, Arnd Bergmann a ?crit : > During my randconfig build testing, I found that a kernel with > DEBUG_AT91_UART and ARCH_BCM_63XX fails to build: > > arch/arm/include/debug/at91.S:18:0: error: "CONFIG_DEBUG_UART_VIRT" redefined [-Werror] > > It turns out that the DEBUG_UART_BCM63XX option is enabled whenever > the ARCH_BCM_63XX is, and that breaks multiplatform kernels because > we then end up using the UART address from BCM63XX rather than the > one we actually configured (if any). > > This changes the BCM63XX options to only have one Kconfig option, > and only enable that if the user explicitly turns it on. > > Signed-off-by: Arnd Bergmann > Fixes: b51312bebfa4 ("ARM: BCM63XX: add low-level UART debug support") > Cc: stable at vger.kernel.org Acked-by: Florian Fainelli Thanks for spotting this. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756341AbcARTHM (ORCPT ); Mon, 18 Jan 2016 14:07:12 -0500 Received: from mail-ob0-f171.google.com ([209.85.214.171]:34532 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756322AbcARTHJ (ORCPT ); Mon, 18 Jan 2016 14:07:09 -0500 Subject: Re: [PATCH] ARM: debug-ll: fix BCM63xx entry for multiplatform To: Arnd Bergmann References: <5641204.G6RtGs3Kji@wuerfel> Cc: arm@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Florian Fainelli X-Enigmail-Draft-Status: N1110 Message-ID: <569D37DA.7090309@gmail.com> Date: Mon, 18 Jan 2016 11:07:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <5641204.G6RtGs3Kji@wuerfel> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 18/01/2016 01:51, Arnd Bergmann a écrit : > During my randconfig build testing, I found that a kernel with > DEBUG_AT91_UART and ARCH_BCM_63XX fails to build: > > arch/arm/include/debug/at91.S:18:0: error: "CONFIG_DEBUG_UART_VIRT" redefined [-Werror] > > It turns out that the DEBUG_UART_BCM63XX option is enabled whenever > the ARCH_BCM_63XX is, and that breaks multiplatform kernels because > we then end up using the UART address from BCM63XX rather than the > one we actually configured (if any). > > This changes the BCM63XX options to only have one Kconfig option, > and only enable that if the user explicitly turns it on. > > Signed-off-by: Arnd Bergmann > Fixes: b51312bebfa4 ("ARM: BCM63XX: add low-level UART debug support") > Cc: stable@vger.kernel.org Acked-by: Florian Fainelli Thanks for spotting this. -- Florian