From: Guenter Roeck <linux@roeck-us.net>
To: Mason <slash.tmp@free.fr>, Wim Van Sebroeck <wim@iguana.be>
Cc: Mans Rullgard <mans@mansr.com>, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: tango: rename ARCH_TANGOX to ARCH_TANGO
Date: Mon, 18 Jan 2016 12:27:59 -0800 [thread overview]
Message-ID: <569D4ACF.6020701@roeck-us.net> (raw)
In-Reply-To: <569D421C.30504@free.fr>
On 01/18/2016 11:50 AM, Mason wrote:
> From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
>
> Requested by arm-soc maintainer Kevin Hilman in v9 review.
> http://article.gmane.org/gmane.linux.ports.arm.kernel/456331
>
The reference should be after the '---' (it doesn't explain
the changes, but provides a reference to the change request),
and the explanation should be what you have after '---' below,
ie that the architecture is tango, that the 'x' is a wildcard,
and that it therefore makes more sense to use ARCH_TANGO
instead of ARCH_TANGOX.
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> ---
> Can this fix be pushed into 4.5 ?
>
Depends. Is the definition of ARCH_TANGO going to make it in ?
Guenter
> (The 'x' in tangox is a wild-card; tango3 is legacy,
> tango4 is current, tango5 is next.)
> ---
> drivers/watchdog/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 4f0e7be0da34..e723e0169f88 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -145,7 +145,7 @@ config MENF21BMC_WATCHDOG
> config TANGOX_WATCHDOG
> tristate "Sigma Designs SMP86xx/SMP87xx watchdog"
> select WATCHDOG_CORE
> - depends on ARCH_TANGOX || COMPILE_TEST
> + depends on ARCH_TANGO || COMPILE_TEST
> help
> Support for the watchdog in Sigma Designs SMP86xx (tango3)
> and SMP87xx (tango4) family chips.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-01-18 20:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 19:50 [PATCH] watchdog: tango: rename ARCH_TANGOX to ARCH_TANGO Mason
2016-01-18 20:27 ` Guenter Roeck [this message]
2016-01-19 10:32 ` Mason
2016-01-19 12:15 ` Mason
2016-01-19 12:35 ` Måns Rullgård
2016-01-19 13:08 ` Guenter Roeck
2016-01-19 13:18 ` Guenter Roeck
2016-01-21 14:36 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569D4ACF.6020701@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=mans@mansr.com \
--cc=slash.tmp@free.fr \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.