From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLHKU-0003jj-B6 for qemu-devel@nongnu.org; Mon, 18 Jan 2016 16:27:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLHKQ-0000gN-B6 for qemu-devel@nongnu.org; Mon, 18 Jan 2016 16:27:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLHKQ-0000gE-5e for qemu-devel@nongnu.org; Mon, 18 Jan 2016 16:27:10 -0500 References: <1453138544-8457-1-git-send-email-peter.maydell@linaro.org> <569D282C.8050407@suse.de> From: Eric Blake Message-ID: <569D58AC.3090904@redhat.com> Date: Mon, 18 Jan 2016 14:27:08 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jpbLxv2NMkSWUtBqCsBuag3rLGS8Wx2m9" Subject: Re: [Qemu-devel] [PATCH] cpu: Clean up includes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , =?UTF-8?Q?Andreas_F=c3=a4rber?= Cc: QEMU Developers , Patch Tracking This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jpbLxv2NMkSWUtBqCsBuag3rLGS8Wx2m9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/18/2016 11:05 AM, Peter Maydell wrote: >>> +++ b/qom/cpu.c >>> @@ -18,6 +18,7 @@ >>> * >>> */ >>> >>> +#include "qemu/osdep.h" >>> #include "qemu-common.h" >> >> Shouldn't qemu-common.h include osdep.h? >=20 > It does, but the intention is that every .c file should include > qemu/osdep.h as its first include (even if some other include > it has also results in osdep.h being pulled in). Eventually, we want to force that NO .h file includes qemu/osdep.h. If every .c file includes it first, then all other .h files can count on it already being included and therefore don't need to include it themselves. (This is comparable to the rule used in other projects, like libvirt's handling of config.h which must be first in all .c files and must not be included in .h files). > This is a simple > rule that's easy to check in code review and hopefully also > in an automated way. Indeed - we MUST turn on automation after all these individual patches are in, to make sure we don't regress (again, something that libvirt has already managed to do, so it shouldn't be too hard to automate, except that libvirt's automation is courtesy of gnulib which we don't use here).= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jpbLxv2NMkSWUtBqCsBuag3rLGS8Wx2m9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWnVitAAoJEKeha0olJ0Nq398H/jell2R9BZ7QBuysf6vcO625 tVbrBFmUzMBaqp90AzUl0UV4oUQ+9rztLedoUaLsNh3rDxuYXtORdyLsbKoqB6W3 efZ1hYI7r2+AAqwMNuy0yKNev0JoADmWtN3lLp+qYr4OeiPhNAm6tGQAAmx3j4bY L/941uyrsMEoVrtwaZU0E34Q2heXClDWAcvsbdkRq8p1UrNQuH9UcOf/VWCBsEWe y3fVOjR2ABsva9Wd1cSinExGT0FkAhBXp6eZS6IPo8cWChh1x8UMxAqkN/Ie10uD qraN7N4o06zFtyk4xrPUte+MOnbinQuuDI6DFHEwR7bfXdmvGb5ovweqVTgL6nM= =imUG -----END PGP SIGNATURE----- --jpbLxv2NMkSWUtBqCsBuag3rLGS8Wx2m9--