From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLLKR-0007qc-1A for qemu-devel@nongnu.org; Mon, 18 Jan 2016 20:43:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLLKN-0007Tg-Sd for qemu-devel@nongnu.org; Mon, 18 Jan 2016 20:43:26 -0500 Received: from [59.151.112.132] (port=54291 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLLKN-0007TM-Gy for qemu-devel@nongnu.org; Mon, 18 Jan 2016 20:43:23 -0500 References: <569CC67C.4030307@gmail.com> From: Cao jin Message-ID: <569D957E.8060900@cn.fujitsu.com> Date: Tue, 19 Jan 2016 09:46:38 +0800 MIME-Version: 1.0 In-Reply-To: <569CC67C.4030307@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v16 09/14] add check reset mechanism when hotplug vfio device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcel@redhat.com, qemu-devel@nongnu.org Cc: chen.fan.fnst@cn.fujitsu.com, izumi.taku@jp.fujitsu.com, alex.williamson@redhat.com, mst@redhat.com On 01/18/2016 07:03 PM, Marcel Apfelbaum wrote: > On 01/12/2016 04:43 AM, Cao jin wrote: >> From: Chen Fan >> >> Since we support multi-function hotplug. the function 0 indicate > > I think you wanted , instead of ., also I would suggest > "..., function 0 indicates..." > >> the closure of the slot, so we have the chance to do the check. >> +static int pci_bus_hotplug_notifier(PCIBus *bus, void *opaque) > > Maybe pci_bus_hotplug_notify instead of pci_bus_hotplug_notifier > > > Thanks, > Marcel > Sure, thanks for all the correction, will update it -- Yours Sincerely, Cao jin