All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel@daenzer.net>
To: "Emil Velikov" <emil.l.velikov@gmail.com>,
	"Marek Olšák" <maraeo@gmail.com>
Cc: ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] configure.ac: disable annoying warning -Wmissing-field-initializers
Date: Tue, 19 Jan 2016 12:42:09 +0900	[thread overview]
Message-ID: <569DB091.3090602@daenzer.net> (raw)
In-Reply-To: <CACvgo50SpAorscazETicyrTyHaTYKBDAnUyKruT1_jrP-TmdUA@mail.gmail.com>

On 19.01.2016 01:05, Emil Velikov wrote:
> 
> A few of those are already implicit with either Wall or Wextra. Both
> of which, imho, are a must have for any serious project.

I think -Wextra is generally too noisy for that, but I guess we're now
deeply in arguing about taste territory.


> But seriously - it makes me think that people are rushed to write the
> code and get it out. Or perhaps a too strong "no warnings" policy ?
> After all warnings are to hint that things can be improved/might be
> wrong. If it looks trivial, just ignore it :-)

One problem with that is that leaving trivial/irrelevant/incorrect
warnings makes it easier to miss important warnings. That being said, I
fully agree that one should resist the urge to just get rid of warnings
in whatever way. (I tend to cringe whenever a commit log says something
along the lines of "fix warning" — a change either fixes a problem which
was pointed out by the warning, or it just silences the warning.)


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-01-19  3:42 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12 21:14 [PATCH] configure.ac: disable annoying warning -Wmissing-field-initializers Marek Olšák
2016-01-15 11:12 ` Emil Velikov
2016-01-15 15:24   ` Marek Olšák
2016-01-16 19:46     ` David Herrmann
2016-01-18 14:45     ` Emil Velikov
2016-01-18 15:43       ` Marek Olšák
2016-01-18 15:51         ` Jani Nikula
2016-01-18 16:05         ` Emil Velikov
2016-01-18 22:53           ` Marek Olšák
2016-01-21 10:51             ` Emil Velikov
2016-01-21 12:08               ` Marek Olšák
2016-01-21 13:09                 ` Emil Velikov
2016-01-21 16:58                   ` Marek Olšák
2016-01-22 17:13                     ` Emil Velikov
2016-01-22 17:18                       ` Marek Olšák
2016-01-22 17:29                         ` Ilia Mirkin
2016-01-22 17:40                           ` Emil Velikov
2016-01-22 17:47                             ` Ville Syrjälä
2016-01-22 17:48                               ` Ilia Mirkin
2016-01-22 19:18                                 ` Jan Vesely
2016-01-22 17:50                               ` Emil Velikov
2016-01-22 17:59                                 ` Emil Velikov
2016-01-22 18:49                                   ` Ville Syrjälä
2016-01-22 19:21                                     ` Emil Velikov
2016-01-22 19:33                                       ` Ville Syrjälä
2016-01-19  3:42           ` Michel Dänzer [this message]
2016-01-16 19:49 ` Ilia Mirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569DB091.3090602@daenzer.net \
    --to=michel@daenzer.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=maraeo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.