From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Zhao Subject: Re: [PATCH v4 04/10] acpi: Don't do traditional BIOS table scan for ARM64 Date: Tue, 19 Jan 2016 11:46:32 +0800 Message-ID: <569DB198.700@huawei.com> References: <1452920477-13916-1-git-send-email-zhaoshenglong@huawei.com> <1452920477-13916-5-git-send-email-zhaoshenglong@huawei.com> <569CF6D102000078000C8062@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <569CF6D102000078000C8062@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: ian.campbell@citrix.com, peter.huangpeng@huawei.com, xen-devel@lists.xen.org, julien.grall@citrix.com, stefano.stabellini@citrix.com, shannon.zhao@linaro.org List-Id: xen-devel@lists.xenproject.org On 2016/1/18 21:29, Jan Beulich wrote: >>>> On 16.01.16 at 06:01, wrote: >> > --- a/xen/drivers/acpi/tables/tbxfroot.c >> > +++ b/xen/drivers/acpi/tables/tbxfroot.c >> > @@ -49,6 +49,12 @@ >> > #define _COMPONENT ACPI_TABLES >> > ACPI_MODULE_NAME("tbxfroot") >> > >> > +#ifdef CONFIG_ARM >> > +acpi_status __init acpi_find_root_pointer(acpi_native_uint * table_address) >> > +{ >> > + return_ACPI_STATUS(AE_NOT_FOUND); >> > +} >> > +#else >> > /* Local prototypes */ >> > static u8 *acpi_tb_scan_memory_for_rsdp(u8 * start_address, u32 length); >> > >> > @@ -271,3 +277,4 @@ static u8 *__init acpi_tb_scan_memory_for_rsdp(u8 * start_address, u32 length) >> > start_address)); >> > return_PTR(NULL); >> > } >> > +#endif > You modify ACPI CA code here, which should be avoided if at all > possible. Why don't you simply port over Linux'es solution (which > changes osl.c instead), the more that now we have Linux-like > Kconfig? Of course I can and I suggested this way at v3 but ... Hope this your final suggestion. Thanks in advance! -- Shannon