From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Tue, 19 Jan 2016 09:33:39 +0100 Subject: [PATCH] clocksource: atmel-st: use return value from clk_prepare_enable() In-Reply-To: <1453145698-23661-1-git-send-email-alexandre.belloni@free-electrons.com> References: <1453145698-23661-1-git-send-email-alexandre.belloni@free-electrons.com> Message-ID: <569DF4E3.2000302@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 18/01/2016 20:34, Alexandre Belloni a ?crit : > ret is used to detect an error but it was not properly updated after > calling clk_prepare_enable() thus it made it impossible to detect an error > when enabling the slow clock. > > Signed-off-by: Alexandre Belloni > --- > drivers/clocksource/timer-atmel-st.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c > index 29d21d68df5a..c69070c6ad91 100644 > --- a/drivers/clocksource/timer-atmel-st.c > +++ b/drivers/clocksource/timer-atmel-st.c > @@ -225,7 +225,7 @@ static void __init atmel_st_timer_init(struct device_node *node) > if (IS_ERR(sclk)) > panic(pr_fmt("Unable to get slow clock\n")); > > - clk_prepare_enable(sclk); > + ret = clk_prepare_enable(sclk); Yes, sure... Acked-by: Nicolas Ferre Thanks! > if (ret) > panic(pr_fmt("Could not enable slow clock\n")); > > -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757483AbcASIdq (ORCPT ); Tue, 19 Jan 2016 03:33:46 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:2417 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751786AbcASIdo (ORCPT ); Tue, 19 Jan 2016 03:33:44 -0500 Subject: Re: [PATCH] clocksource: atmel-st: use return value from clk_prepare_enable() To: Alexandre Belloni , Daniel Lezcano References: <1453145698-23661-1-git-send-email-alexandre.belloni@free-electrons.com> CC: Thomas Gleixner , Boris Brezillon , , From: Nicolas Ferre Organization: atmel Message-ID: <569DF4E3.2000302@atmel.com> Date: Tue, 19 Jan 2016 09:33:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1453145698-23661-1-git-send-email-alexandre.belloni@free-electrons.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 18/01/2016 20:34, Alexandre Belloni a écrit : > ret is used to detect an error but it was not properly updated after > calling clk_prepare_enable() thus it made it impossible to detect an error > when enabling the slow clock. > > Signed-off-by: Alexandre Belloni > --- > drivers/clocksource/timer-atmel-st.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c > index 29d21d68df5a..c69070c6ad91 100644 > --- a/drivers/clocksource/timer-atmel-st.c > +++ b/drivers/clocksource/timer-atmel-st.c > @@ -225,7 +225,7 @@ static void __init atmel_st_timer_init(struct device_node *node) > if (IS_ERR(sclk)) > panic(pr_fmt("Unable to get slow clock\n")); > > - clk_prepare_enable(sclk); > + ret = clk_prepare_enable(sclk); Yes, sure... Acked-by: Nicolas Ferre Thanks! > if (ret) > panic(pr_fmt("Could not enable slow clock\n")); > > -- Nicolas Ferre