From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLaaW-0003gT-OF for qemu-devel@nongnu.org; Tue, 19 Jan 2016 13:01:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLaaT-00074y-Av for qemu-devel@nongnu.org; Tue, 19 Jan 2016 13:01:04 -0500 Sender: Paolo Bonzini References: <1453208963-16834-1-git-send-email-berrange@redhat.com> <1453208963-16834-5-git-send-email-berrange@redhat.com> <569E5F6C.5020404@redhat.com> <20160119165241.GS26662@redhat.com> From: Paolo Bonzini Message-ID: <569E79D0.2020504@redhat.com> Date: Tue, 19 Jan 2016 19:00:48 +0100 MIME-Version: 1.0 In-Reply-To: <20160119165241.GS26662@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 04/13] nbd: convert to using I/O channels for actual socket I/O List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org On 19/01/2016 17:52, Daniel P. Berrange wrote: > I'll have a look at this and see what I can do. It shouldn't block > merging of this patch I assume, since the current call to > qemu_coroutine_yield() should be fine - it just my comment suggestion > that would not work. Yes, that is tied to negotiations being always in the main loop. I'm not entirely sure that is the case (e.g. a call bdrv_reopen could perhaps be from somewhere else) but it's anyway no worse than the current state. Paolo