All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yu Dai <yu.dai@intel.com>
To: Arun Siluvery <arun.siluvery@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/gen9: Correct max save/restore register count during gpu reset with GuC
Date: Tue, 19 Jan 2016 10:13:43 -0800	[thread overview]
Message-ID: <569E7CD7.2030301@intel.com> (raw)
In-Reply-To: <1453132776-22229-1-git-send-email-arun.siluvery@linux.intel.com>

Thanks for capture the typo. LGTM.

Reviewed-by: Alex Dai <yu.dai@intel.com>

On 01/18/2016 07:59 AM, Arun Siluvery wrote:
> In GuC submission mode, driver has to provide a list of registers to be
> save/restored during gpu reset, make the max no. of registers value consistent
> with that of the value defined in FW. If they are not in sync then register
> save/restore during gpu reset won't work as expected.
>
> Cc: Alex Dai <yu.dai@intel.com>
> Cc: Dave Gordon <david.s.gordon@intel.com>
> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
> ---
>   drivers/gpu/drm/i915/intel_guc_fwif.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h b/drivers/gpu/drm/i915/intel_guc_fwif.h
> index 130d94c..1d8048b 100644
> --- a/drivers/gpu/drm/i915/intel_guc_fwif.h
> +++ b/drivers/gpu/drm/i915/intel_guc_fwif.h
> @@ -370,7 +370,7 @@ struct guc_policies {
>   #define GUC_REGSET_SAVE_DEFAULT_VALUE	0x8
>   #define GUC_REGSET_SAVE_CURRENT_VALUE	0x10
>   
> -#define GUC_REGSET_MAX_REGISTERS	20
> +#define GUC_REGSET_MAX_REGISTERS	25
>   #define GUC_MMIO_WHITE_LIST_START	0x24d0
>   #define GUC_MMIO_WHITE_LIST_MAX		12
>   #define GUC_S3_SAVE_SPACE_PAGES		10

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-01-19 18:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18 15:59 [PATCH] drm/i915/gen9: Correct max save/restore register count during gpu reset with GuC Arun Siluvery
2016-01-18 16:20 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-01-18 16:29   ` Arun Siluvery
2016-01-19 17:51   ` Arun Siluvery
2016-01-19 18:13 ` Yu Dai [this message]
2016-01-19 19:38   ` [PATCH] " Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569E7CD7.2030301@intel.com \
    --to=yu.dai@intel.com \
    --cc=arun.siluvery@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.