From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLdnF-0006v9-UB for qemu-devel@nongnu.org; Tue, 19 Jan 2016 16:26:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLdnA-0000Or-VZ for qemu-devel@nongnu.org; Tue, 19 Jan 2016 16:26:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLdnA-0000Ol-QF for qemu-devel@nongnu.org; Tue, 19 Jan 2016 16:26:20 -0500 References: <1453115127-10667-1-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <569EA9FA.4000806@redhat.com> Date: Tue, 19 Jan 2016 14:26:18 -0700 MIME-Version: 1.0 In-Reply-To: <1453115127-10667-1-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cSP0VPKeVuwObAEjnl186pxFn01Fjc3IM" Subject: Re: [Qemu-devel] [PATCH v3] s390: use FILE instead of QEMUFile for creating text file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Cornelia Huck , "Jason J. Herne" , Richard Henderson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cSP0VPKeVuwObAEjnl186pxFn01Fjc3IM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/18/2016 04:05 AM, Daniel P. Berrange wrote: > The s390 skeys monitor command needs to write out a plain text > file. Currently it is using the QEMUFile class for this, but > work is ongoing to refactor QEMUFile and eliminate much code > related to it. The only feature qemu_fopen() gives over fopen() > is support for QEMU FD passing, but this can be achieved with > qemu_open() + fdopen() too. Switching to regular stdio FILE > APIs avoids the need to sprintf via an intermediate buffer > which slightly simplifies the code. >=20 > Signed-off-by: Daniel P. Berrange > --- > hw/s390x/s390-skeys.c | 26 ++++++++++++++------------ > 1 file changed, 14 insertions(+), 12 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cSP0VPKeVuwObAEjnl186pxFn01Fjc3IM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWnqn7AAoJEKeha0olJ0NqvdsH/jkK8JCvgvoK6ETxm7gmr6IR OaQu2ongHcoEpuiaP+96cjKA16kMKJHlSK+ZLEkGJ454CBRqIsPosU+7TL6tFjYH 9KODoggLSDt1+P56F6vNVZCVX5QSy8Pxjlp0TxIY4DrXgBEdAcOvi4hgJ8v2hWko vwrg/STJU1FLGdthfi55Jh5cX8C736FXq51LL9zNv3SmA0Fuy4g5QiihWu7Z4uOS 4LcUHi/hXOahS+NM7A/TjYSfaC22SBrD2SLFsWawyRjtVHcpdB/xpOmDarFJokBx GGjnxMS/B0EGON0mXF+XuvSebdsSkFgPBL11AMlBqEtlJvq9sHLcc+ySGIeqqOc= =s/Yj -----END PGP SIGNATURE----- --cSP0VPKeVuwObAEjnl186pxFn01Fjc3IM--