From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [PATCH V13 5/5] xl: add pvusb commands Date: Tue, 19 Jan 2016 20:10:07 -0700 Message-ID: <569EFA8F.1000301@suse.com> References: <1453192795-15693-1-git-send-email-cyliu@suse.com> <1453192795-15693-6-git-send-email-cyliu@suse.com> <22174.31841.372743.506457@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <22174.31841.372743.506457@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , Chunyan Liu Cc: jgross@suse.com, wei.liu2@citrix.com, ian.campbell@citrix.com, george.dunlap@eu.citrix.com, xen-devel@lists.xen.org, Simon Cao List-Id: xen-devel@lists.xenproject.org On 01/19/2016 11:11 AM, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH V13 5/5] xl: add pvusb commands"): >> Add pvusb commands: usbctrl-attach, usbctrl-detach, usb-list, >> usbdev-attach and usbdev-detach. > Thanks for swapping this with the other patch. It is better now. > >> +=item B I I > However, I think you need to explictly state that the user may (and > indeed, must) pass multiple settings as separate arguments. AFAICT > the parser here doesn't do the ,-splitting. I just noticed this is the case with network devices as well. E.g. #xl network-attach hvm-domU mac=00:16:3e:xx:yy:zz,bridge=br0 libxl: error: libxl_device.c:1095:device_hotplug_child_death_cb: script: Could not find bridge device xenbr0 main_networkattach() in tools/libxl/xl_cmdimpl.c doesn't split on the ',', so everything after mac=00:16:3e:xx:yy:zz is ignored. I'd need advice on how to fix this though. Based on xl-network-configuration doc and Xen tool's long history of network-attach supporting that syntax, I'd say main_networkattach() should be changed to split on ','. I could also change the docs. Do tools maintainers have a preference, or alternative option? Regards, Jim