From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLkro-0007u9-1m for qemu-devel@nongnu.org; Tue, 19 Jan 2016 23:59:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLkrk-0003Mx-SW for qemu-devel@nongnu.org; Tue, 19 Jan 2016 23:59:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53151) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLkrk-0003Ms-LK for qemu-devel@nongnu.org; Tue, 19 Jan 2016 23:59:32 -0500 References: <1453117322-30191-1-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <569F1432.3060101@redhat.com> Date: Tue, 19 Jan 2016 21:59:30 -0700 MIME-Version: 1.0 In-Reply-To: <1453117322-30191-1-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0D1rX2Gtg1ti0aVXmFwawxf0XVCM4NUOs" Subject: Re: [Qemu-devel] [PATCH 1/1] nvdimm: disable balloon List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Vladimir Sementsov-Ogievskiy , Xiao Guangrong , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi , Igor Mammedov This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0D1rX2Gtg1ti0aVXmFwawxf0XVCM4NUOs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/18/2016 04:42 AM, Denis V. Lunev wrote: > From: Vladimir Sementsov-Ogievskiy >=20 > NVDIMM for now is planned to use as a backing store for DAX filesystem > in the guest and thus this memory is excluded from guest memory managem= ent > and LRUs. >=20 > In this case libvirt running QEMU along with configured ballon almost s/ballon/balloon/ > immediately inflates balloon and effectively kill the guest as > qemu counts nvdimm as part of the ram. >=20 > Counting dimm devices as part of the ram for ballooning was started fro= m > patch > virtio-balloon: Fix balloon not working correctly when hotplug memory Useful to mention the commit id: 463756d03 >=20 > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Xiao Guangrong > CC: "Michael S. Tsirkin" > CC: Igor Mammedov > CC: Eric Blake > CC: Markus Armbruster I'm just doing an interface review. > --- > The patch is submitted start a discussion. It may be technically correc= t, > but for us the situation is a bit shady. >=20 > +++ b/qapi-schema.json > @@ -3922,6 +3922,8 @@ > # > # @hotpluggable: true if device if could be added/removed while machin= e is running > # > +# @in-ram: true if device if should be counted in current ram size (si= nce 2.6) Output-only, so you are okay adding a new non-optional field. However, is "should be counted" the right wording, or would it be better as "is counted", given that the user doesn't have any way to change whether a device gets counted or not, but is merely learning the state previously chosen by the device. As for whether it makes sense technically, I'll leave that to discussion.= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --0D1rX2Gtg1ti0aVXmFwawxf0XVCM4NUOs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWnxQyAAoJEKeha0olJ0Nqr+gH/2u09SssZn4I57nSILdGhEQr x3rb7nN8kdTVVbhA9DtSUSx8CUD5E44woXkiAT1ebb7BYYvBNeQBTPNMG00liu2H e3P361E9yTwvijhaPX3r3Ran8u45bykJ6JvIUxCDrmEYXwmBgIB3y821dgWuAR1A G916wTEj1ekBn/jshI5fKIsX0/TDNVY+X4+AlBwLXMHvurmnsxo0yZsKE9llJhzK Q20juj+3joOUd6V3j9sg/FSpNDgXkwNSjBwKaU5coEMzkMMFLbsH58wEvIOQUITp SmdNGScedmut3tyvvdIOmv1RxZJ/0QzkYVbMD5TLqrXGg2Sy4fBWcBzySg3jolA= =N6uE -----END PGP SIGNATURE----- --0D1rX2Gtg1ti0aVXmFwawxf0XVCM4NUOs--