From mboxrd@z Thu Jan 1 00:00:00 1970 From: wenyou.yang@atmel.com (Yang, Wenyou) Date: Wed, 20 Jan 2016 15:50:29 +0800 Subject: [PATCH v5 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver In-Reply-To: <87d1swvgv8.fsf@dell.be.48ers.dk> References: <1452747845-2962-1-git-send-email-wenyou.yang@atmel.com> <1452747845-2962-2-git-send-email-wenyou.yang@atmel.com> <87pox41dy9.fsf@dell.be.48ers.dk> <8737tzz33h.fsf@dell.be.48ers.dk> <87d1swvgv8.fsf@dell.be.48ers.dk> Message-ID: <569F3C45.7090109@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Peter, On 2016/1/20 15:40, Peter Korsgaard wrote: >>>>>> "Yang," == Yang, Wenyou writes: > Hi, > >>> But the charger driver can just as well do: > >> > >> dev_get_regmap(dev->parent); > >> > >> instead of: > >> > >> dev_get_drvdata(pdev->dev.parent)->regmap. > > > For regulator, it works use the core do dev_get_regmap(dev->parent), > > but for charger, it need to export *act8945a. > > Why? There is a callback (*get_property)(...), who will read the charger register via regmap, but it doesn't provide the argument for regmap. include/linux/power_supply.h struct power_supply_desc { [ ... ] int (*get_property)(struct power_supply *psy, enum power_supply_property psp, union power_supply_propval *val); [ ... ] } > > Just like the regulator core does, your battery driver can do: > > dev_get_regmap(dev->parent); > Best Regards, Wenyou Yang From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yang, Wenyou" Subject: Re: [PATCH v5 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver Date: Wed, 20 Jan 2016 15:50:29 +0800 Message-ID: <569F3C45.7090109@atmel.com> References: <1452747845-2962-1-git-send-email-wenyou.yang@atmel.com> <1452747845-2962-2-git-send-email-wenyou.yang@atmel.com> <87pox41dy9.fsf@dell.be.48ers.dk> <8737tzz33h.fsf@dell.be.48ers.dk> <87d1swvgv8.fsf@dell.be.48ers.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87d1swvgv8.fsf-D6SC8u56vOOJDPpyT6T3/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Korsgaard Cc: Lee Jones , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Krzysztof Kozlowski , "Ferre, Nicolas" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Javier Martinez Canillas , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi Peter, On 2016/1/20 15:40, Peter Korsgaard wrote: >>>>>> "Yang," == Yang, Wenyou writes: > Hi, > >>> But the charger driver can just as well do: > >> > >> dev_get_regmap(dev->parent); > >> > >> instead of: > >> > >> dev_get_drvdata(pdev->dev.parent)->regmap. > > > For regulator, it works use the core do dev_get_regmap(dev->parent), > > but for charger, it need to export *act8945a. > > Why? There is a callback (*get_property)(...), who will read the charger register via regmap, but it doesn't provide the argument for regmap. include/linux/power_supply.h struct power_supply_desc { [ ... ] int (*get_property)(struct power_supply *psy, enum power_supply_property psp, union power_supply_propval *val); [ ... ] } > > Just like the regulator core does, your battery driver can do: > > dev_get_regmap(dev->parent); > Best Regards, Wenyou Yang -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758065AbcATHvV (ORCPT ); Wed, 20 Jan 2016 02:51:21 -0500 Received: from nasmtp01.atmel.com ([192.199.1.245]:16813 "EHLO DVREDG01.corp.atmel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750913AbcATHvL (ORCPT ); Wed, 20 Jan 2016 02:51:11 -0500 Subject: Re: [PATCH v5 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver To: Peter Korsgaard References: <1452747845-2962-1-git-send-email-wenyou.yang@atmel.com> <1452747845-2962-2-git-send-email-wenyou.yang@atmel.com> <87pox41dy9.fsf@dell.be.48ers.dk> <8737tzz33h.fsf@dell.be.48ers.dk> <87d1swvgv8.fsf@dell.be.48ers.dk> CC: Lee Jones , Rob Herring , Pawel Moll , Mark Rutland , "Ian Campbell" , Kumar Gala , "devicetree@vger.kernel.org" , "Krzysztof Kozlowski" , "Ferre, Nicolas" , "linux-kernel@vger.kernel.org" , Javier Martinez Canillas , "linux-arm-kernel@lists.infradead.org" From: "Yang, Wenyou" Message-ID: <569F3C45.7090109@atmel.com> Date: Wed, 20 Jan 2016 15:50:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <87d1swvgv8.fsf@dell.be.48ers.dk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.168.5.13] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On 2016/1/20 15:40, Peter Korsgaard wrote: >>>>>> "Yang," == Yang, Wenyou writes: > Hi, > >>> But the charger driver can just as well do: > >> > >> dev_get_regmap(dev->parent); > >> > >> instead of: > >> > >> dev_get_drvdata(pdev->dev.parent)->regmap. > > > For regulator, it works use the core do dev_get_regmap(dev->parent), > > but for charger, it need to export *act8945a. > > Why? There is a callback (*get_property)(...), who will read the charger register via regmap, but it doesn't provide the argument for regmap. include/linux/power_supply.h struct power_supply_desc { [ ... ] int (*get_property)(struct power_supply *psy, enum power_supply_property psp, union power_supply_propval *val); [ ... ] } > > Just like the regulator core does, your battery driver can do: > > dev_get_regmap(dev->parent); > Best Regards, Wenyou Yang