From: "Sean Nyekjær" <sean.nyekjaer@prevas.dk>
To: Rob Herring <robh@kernel.org>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCHv3 2/2] gpio: sn65hvs885: Add DT binding documentation
Date: Wed, 20 Jan 2016 13:45:33 +0100 [thread overview]
Message-ID: <569F816D.1000309@prevas.dk> (raw)
In-Reply-To: <20160119172040.GA8857@rob-hp-laptop>
Hi
Yes i need to add the gpio-controller and #gpio-cells. But i'm not
exactly sure what gpio-cells means and its difficult to find in
documentation.
I found this in the documentation:
#gpio-cells: The first cell is the GPIO number and the second cell is
used to specify the GPIO polarity.
This device only supports inputs so the gpio-cells option needs to be
<1> or ??
#gpio-cells = <1>;
/Sean
On 2016-01-19 18:20, Rob Herring wrote:
> On Tue, Jan 19, 2016 at 11:22:20AM +0100, Sean Nyekjaer wrote:
>> Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
>> ---
>> Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt b/Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt
>> new file mode 100644
>> index 0000000..56679ac
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt
>> @@ -0,0 +1,9 @@
>> +* TI SN65HVS885 digital-input serializer
>> +
>> +Example:
>> + sn65hvs885@3 {
>> + compatible = "sn65hvs885";
>> + spi-max-frequency = <10000000>;
>> + reg = <0>;
> What about all the standard gpio controller properties?
>
>> + };
>> +
>> --
>> 2.7.0
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-20 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 10:22 [PATCHv3 1/2] gpio: add TI SN65HVS885 spi industrial input serializer driver Sean Nyekjaer
2016-01-19 10:22 ` [PATCHv3 2/2] gpio: sn65hvs885: Add DT binding documentation Sean Nyekjaer
2016-01-19 17:20 ` Rob Herring
2016-01-20 12:45 ` Sean Nyekjær [this message]
2016-01-20 22:25 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569F816D.1000309@prevas.dk \
--to=sean.nyekjaer@prevas.dk \
--cc=devicetree@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.