From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLvsE-0007Xh-WC for qemu-devel@nongnu.org; Wed, 20 Jan 2016 11:44:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLvsA-00031v-1w for qemu-devel@nongnu.org; Wed, 20 Jan 2016 11:44:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLvs9-00031r-SQ for qemu-devel@nongnu.org; Wed, 20 Jan 2016 11:44:41 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 6DC5BF5DD9 for ; Wed, 20 Jan 2016 16:44:41 +0000 (UTC) References: <1453208789-42479-1-git-send-email-imammedo@redhat.com> <1453208789-42479-6-git-send-email-imammedo@redhat.com> From: Eric Blake Message-ID: <569FB978.6070906@redhat.com> Date: Wed, 20 Jan 2016 09:44:40 -0700 MIME-Version: 1.0 In-Reply-To: <1453208789-42479-6-git-send-email-imammedo@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UFpDTg54xItLkSQV3uQhjKGubaPq0pu05" Subject: Re: [Qemu-devel] [PATCH v17 5/9] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: ehabkost@redhat.com, mst@redhat.com, ghammer@redhat.com, lcapitulino@redhat.com, pbonzini@redhat.com, lersek@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UFpDTg54xItLkSQV3uQhjKGubaPq0pu05 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/19/2016 06:06 AM, Igor Mammedov wrote: > Add commands to query Virtual Machine Generation ID counter. >=20 > QMP command example: > { "execute": "query-vm-generation-id" } >=20 > HMP command example: > info vm-generation-id >=20 > Signed-off-by: Igor Mammedov > --- Reviewed-by: Eric Blake > +++ b/qapi-schema.json > @@ -4081,3 +4081,12 @@ > ## > { 'enum': 'ReplayMode', > 'data': [ 'none', 'record', 'play' ] } > + > +## > +# @query-vm-generation-id > +# > +# Show Virtual Machine Generation ID > +# > +# Since 2.6 > +## > +{ 'command': 'query-vm-generation-id', 'returns': 'UuidInfo' } Nice reuse of an existing type, but maybe you want a followup patch to make that type more generically worded (as it is no longer used _just_ for a UUID of the guest): # @UuidInfo: # # Guest UUID information. # # @UUID: the UUID of the guest --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UFpDTg54xItLkSQV3uQhjKGubaPq0pu05 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWn7l4AAoJEKeha0olJ0Nq5rcIAKOL10MZJ3sXJ66/OaBbO2DP 2dfiV4N9PgWtxWTmGVEK6hWlMu6Hxi63It0adSWAzz+UHdwMIw433jeUZtVPrw2B lmh3lJo05AcYCunIr5TxskNaReJ5H51jm1jhqxt6wql/YJY7K1oFqKojTXcNlsqQ 2p6PQkioE3/br3YCfaDvtm7pTlDuVEnAX9v0gSQHRRsj147gOQVmt8T1VeLyB6Zk act/AMbtrCMeCZZMyaYSSEqVaxpooQEQBWkO9uxwJ2hqGAAy2kXSdZaQLSMrRVz7 zsIfJ7lHjLoN5N2Ce4cFtG27VNy+DgtZhwSW/ZTSk3P4/84S7pL/ZwzgijaNG4A= =icQ+ -----END PGP SIGNATURE----- --UFpDTg54xItLkSQV3uQhjKGubaPq0pu05--