All of lore.kernel.org
 help / color / mirror / Atom feed
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/7] ARM: dts: kirkwood: split lswxl dts to linkstation lswsxl and lswxl
Date: Wed, 20 Jan 2016 18:21:43 +0100	[thread overview]
Message-ID: <569FC227.2040300@gmail.com> (raw)
In-Reply-To: <1453304038-28345-7-git-send-email-rogershimizu@gmail.com>

On 01/20/2016 04:33 PM, Roger Shimizu wrote:
> LS-WXL/WSXL are both kirkwood-6281 based 2-Bay NAS devices, which share
> many MPP pins. However they are slightly different:
>    - There're two red LED indicator on LS-WXL to show when HDD fails,
>      but there's no such on LS-WSXL.
>    - There's 4-level speed adjustable FAN on LS-WXL, but not LS-WSXL.
>
> So after the split, common part goes into .dtsi file:
>    - kirkwood-linkstation.dtsi
>    - kirkwood-linkstation-duo-6281.dtsi
> while all rest part goes into device specific .dts file:
>    - kirkwood-linkstation-lswsxl.dts
>    - kirkwood-linkstation-lswxl.dts
>
> Signed-off-by: Roger Shimizu <rogershimizu@gmail.com>
> ---
[...]
> diff --git a/arch/arm/boot/dts/kirkwood-linkstation-duo-6281.dtsi b/arch/arm/boot/dts/kirkwood-linkstation-duo-6281.dtsi
> new file mode 100644
> index 000000000000..47b8f185839d
> --- /dev/null
> +++ b/arch/arm/boot/dts/kirkwood-linkstation-duo-6281.dtsi
> @@ -0,0 +1,185 @@
[...]
> +/ {
> +	ocp at f1000000 {
> +		pinctrl: pin-controller at 10000 {

Roger,

nice series! Mind to send another patch moving pinctrl stuff
and sata below to node references for both boards?

Kirkwood has &pinctrl and &sata labels, it helps to keep the bus
structure out of the board files. &mdio is an example for that.

I might be easier not to squash that into this series but
send another one later.

Sebastian

> +			pmx_power_hdd0: pmx-power-hdd0 {
> +				marvell,pins = "mpp28";
> +				marvell,function = "gpio";
> +			};
[...]
> +		};
> +
> +		sata at 80000 {
> +			nr-ports = <2>;
> +		};
> +	};
[...]
> +};
> +
> +&mdio {
> +	status = "okay";
> +
> +	ethphy1: ethernet-phy at 8 {
> +		device_type = "ethernet-phy";
> +		reg = <8>;
> +	};
> +};
> +
> +&eth1 {
> +	status = "okay";
> +
> +	ethernet1-port at 0 {
> +		phy-handle = <&ethphy1>;
> +	};
> +};

  reply	other threads:[~2016-01-20 17:21 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-19 13:49 [PATCH 0/2] ARM: dts: kirkwood: split lswxl and lswvl with fixes Roger Shimizu
2016-01-19 13:49 ` [PATCH 1/2] ARM: dts: kirkwood: split lswxl into linkstation lswsxl and lswxl Roger Shimizu
2016-01-19 14:05   ` Andrew Lunn
2016-01-19 14:15     ` Roger Shimizu
2016-01-19 14:48       ` Andrew Lunn
2016-01-19 14:56         ` Roger Shimizu
2016-01-20  1:08   ` Andrew Lunn
2016-01-19 13:49 ` [PATCH 2/2] ARM: dts: kirkwood: split lswvl into linkstation lsvl and lswvl Roger Shimizu
2016-01-20 15:33 ` [PATCH v2 0/7] ARM: dts: kirkwood: fixes and split of linkstation dts for ls-wvl/vl and ls-wxl/wsxl Roger Shimizu
2016-01-20 15:33   ` [PATCH v2 1/7] ARM: dts: kirkwood: gpio pin fixes for linkstation ls-wxl/wsxl Roger Shimizu
2016-01-20 17:11     ` Andrew Lunn
2016-01-20 15:33   ` [PATCH v2 2/7] ARM: dts: kirkwood: gpio pin fixes for linkstation ls-wvl/vl Roger Shimizu
2016-01-20 17:12     ` Andrew Lunn
2016-01-20 15:33   ` [PATCH v2 3/7] ARM: dts: kirkwood: gpio-leds fixes for linkstation ls-wxl/wsxl Roger Shimizu
2016-01-20 17:16     ` Andrew Lunn
2016-01-21  0:16       ` Roger Shimizu
2016-01-21  0:30     ` Andrew Lunn
2016-01-20 15:33   ` [PATCH v2 4/7] ARM: dts: kirkwood: gpio-leds fixes for linkstation ls-wvl/vl Roger Shimizu
2016-01-21  0:31     ` Andrew Lunn
2016-01-20 15:33   ` [PATCH v2 5/7] ARM: dts: kirkwood: relicense dts of ls-wvl/vl and ls-wxl/wsxl under GPLv2/X11 Roger Shimizu
2016-01-20 17:18     ` Andrew Lunn
2016-01-20 15:33   ` [PATCH v2 6/7] ARM: dts: kirkwood: split lswxl dts to linkstation lswsxl and lswxl Roger Shimizu
2016-01-20 17:21     ` Sebastian Hesselbarth [this message]
2016-01-21 15:06       ` Roger Shimizu
2016-01-21  0:36     ` Andrew Lunn
2016-01-20 15:33   ` [PATCH v2 7/7] ARM: dts: kirkwood: split lswvl dts to linkstation lsvl and lswvl Roger Shimizu
2016-01-21  0:37     ` Andrew Lunn
2016-01-21 14:38 ` [PATCH v3 0/7] ARM: dts: kirkwood: fixes and split of linkstation dts for ls-wvl/vl and ls-wxl/wsxl Roger Shimizu
2016-01-21 14:38   ` [PATCH v3 1/7] ARM: dts: kirkwood: gpio pin fixes for linkstation ls-wxl/wsxl Roger Shimizu
2016-01-21 14:38   ` [PATCH v3 2/7] ARM: dts: kirkwood: gpio pin fixes for linkstation ls-wvl/vl Roger Shimizu
2016-01-21 14:38   ` [PATCH v3 3/7] ARM: dts: kirkwood: gpio-leds fixes for linkstation ls-wxl/wsxl Roger Shimizu
2016-01-21 14:38   ` [PATCH v3 4/7] ARM: dts: kirkwood: gpio-leds fixes for linkstation ls-wvl/vl Roger Shimizu
2016-01-21 14:38   ` [PATCH v3 5/7] ARM: dts: kirkwood: relicense dts of ls-wvl/vl and ls-wxl/wsxl under GPLv2/X11 Roger Shimizu
2016-01-21 14:38   ` [PATCH v3 6/7] ARM: dts: kirkwood: split lswxl dts to linkstation lswsxl and lswxl Roger Shimizu
2016-01-21 14:38   ` [PATCH v3 7/7] ARM: dts: kirkwood: split lswvl dts to linkstation lsvl and lswvl Roger Shimizu
2016-01-21 16:00   ` [PATCH v3 0/7] ARM: dts: kirkwood: fixes and split of linkstation dts for ls-wvl/vl and ls-wxl/wsxl Gregory CLEMENT
2016-01-21 16:05     ` Roger Shimizu
2016-01-21 16:18       ` Gregory CLEMENT
2016-01-21 16:23         ` Roger Shimizu
2016-01-25 15:17   ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569FC227.2040300@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.