From mboxrd@z Thu Jan 1 00:00:00 1970 From: Edward Cree Subject: Re: ethtool NFC/ntuple API questions Date: Wed, 20 Jan 2016 19:12:04 +0000 Message-ID: <569FDC04.9090509@solarflare.com> References: <569FBF9D.40002@solarflare.com> <1453313223.3734.63.camel@decadent.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: netdev To: Ben Hutchings , Alexander Duyck Return-path: Received: from nbfkord-smmo04.seg.att.com ([209.65.160.86]:45646 "EHLO nbfkord-smmo04.seg.att.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194AbcATTMS (ORCPT ); Wed, 20 Jan 2016 14:12:18 -0500 In-Reply-To: <1453313223.3734.63.camel@decadent.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: Thanks both, it's making more sense now. One thing I'm still unclear about: why does struct ethtool_usrip4_spechave the ip_ver field? The struct can't be extended to cover ipv6, because the address fields aren't big enough. So what's it for? Also, would it be appropriate to use struct in6_addr for IPv6 addresses, or should I use __be32[4]? -Ed