From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLzRz-0000Rb-P0 for qemu-devel@nongnu.org; Wed, 20 Jan 2016 15:33:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLzRy-00056X-P5 for qemu-devel@nongnu.org; Wed, 20 Jan 2016 15:33:55 -0500 References: <1453272694-17106-1-git-send-email-jsnow@redhat.com> <1453272694-17106-4-git-send-email-jsnow@redhat.com> From: Eric Blake Message-ID: <569FEF2C.3050402@redhat.com> Date: Wed, 20 Jan 2016 13:33:48 -0700 MIME-Version: 1.0 In-Reply-To: <1453272694-17106-4-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="doJvXH3hUvJTWkJ7pDDKmHDt0ggPi5ODj" Subject: Re: [Qemu-devel] [PATCH v4 03/12] fdc: add drive type qapi enum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --doJvXH3hUvJTWkJ7pDDKmHDt0ggPi5ODj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/19/2016 11:51 PM, John Snow wrote: > Change the floppy drive type to a QAPI enum type, to allow us to > specify the floppy drive type from the CLI in a forthcoming patch. >=20 > Signed-off-by: John Snow > --- > hw/block/fdc.c | 80 +++++++++++++++++++++++++-----------------= -------- > hw/i386/pc.c | 17 ++++++----- > include/hw/block/fdc.h | 9 +----- > qapi/block.json | 16 ++++++++++ > 4 files changed, 66 insertions(+), 56 deletions(-) >=20 > +++ b/qapi/block.json > @@ -40,6 +40,22 @@ > 'data': ['auto', 'none', 'lba', 'large', 'rechs']} > =20 > ## > +# @FloppyDriveType > +# > +# Type of Floppy drive to be emulated by the Floppy Disk Controller. > +# > +# @144: 1.44MB 3.5" drive > +# @288: 2.88MB 3.5" drive > +# @120: 1.5MB 5.25" drive Umm, how does 120 match with 1.5M? Elsewhere the code comments say: /* 1.2 MB 5"1/4 floppy disks */ With the typo fixed, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --doJvXH3hUvJTWkJ7pDDKmHDt0ggPi5ODj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWn+8sAAoJEKeha0olJ0NqfT0H/R4FcE+H8aRo8IRu9R9ylW4+ 47l1hD3+6ux4Cu7a7Hgvo7drVwxQTmBCPMrMEhNnwqVmTLgQGAG01LoBjs9Iv/3y ONRXOxK5s8PCqyUlYReIe+gskDjZfGQQaXyqxkNR61+q8S2OmiJeSGAg74eEZhzj pAOozwcndMkFju0iAgW+J2ol7eDDWj55r9qnTEWc/08753ha+KRHt972Q812Wz6q ZpMIjSeP6RwhztMMLE/f0Y3w/zSJwEOqhrSXZV+Ir+GZCds7yTtIcCXhmqSpUIvY srtS5a6PJIa7M3FhRuuzX+nNgilwpNdwC8hXYFKIq8Uv5dQaeZv9csz7pJHYWMw= =6/Os -----END PGP SIGNATURE----- --doJvXH3hUvJTWkJ7pDDKmHDt0ggPi5ODj--