From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLzqr-0001XN-6p for qemu-devel@nongnu.org; Wed, 20 Jan 2016 15:59:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLzqq-0003Z3-EV for qemu-devel@nongnu.org; Wed, 20 Jan 2016 15:59:37 -0500 References: <1453272694-17106-1-git-send-email-jsnow@redhat.com> <1453272694-17106-5-git-send-email-jsnow@redhat.com> <569FEF7F.60206@redhat.com> From: John Snow Message-ID: <569FF532.7060203@redhat.com> Date: Wed, 20 Jan 2016 15:59:30 -0500 MIME-Version: 1.0 In-Reply-To: <569FEF7F.60206@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 04/12] fdc: add disk field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-block@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org On 01/20/2016 03:35 PM, Eric Blake wrote: > On 01/19/2016 11:51 PM, John Snow wrote: >> Currently, 'drive' is used both to represent the current diskette >> type as well as the current drive type. >> >> This patch adds a 'disk' field that is updated explicitly to match >> the type of the disk. >> >> As of this patch, disk and drive are always the same, but forthcoming >> patches to change the behavior of pick_geometry will invalidate this >> assumption. >> >> disk does not need to be migrated because it is not user-visible state >> nor is it currently used for any calculations. It is purely informative, >> and will be rebuilt automatically via fd_revalidate on the new host. >> >> Signed-off-by: John Snow >> --- >> hw/block/fdc.c | 3 +++ >> 1 file changed, 3 insertions(+) >> > > Reviewed-by: Eric Blake > Grazie. --js