All of lore.kernel.org
 help / color / mirror / Atom feed
From: subashab@codeaurora.org
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Liping Zhang <zlpnobody@gmail.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH iptables] xtables: use exponential delay when waiting for xtables lock
Date: Thu, 28 Apr 2016 13:14:17 -0600	[thread overview]
Message-ID: <569a5c79f8ca32db942694308c3e1500@codeaurora.org> (raw)
In-Reply-To: <20160428092541.GB1529@salvia>

>> 
>> This break the "-w" option's semantic, i.e. if the user input
>> "iptables -w 1", and concurrency happen,
>> we will just only wait 10ms and return an error.
> 
> If there's any chance this patch can break existing setups then we
> can't take this.
> 
> I'd suggest you add support to express millisecond precision using a
> dot notation, ie.
> 
>         -w .000001
> 
> that means 10 ms.

Thanks Liping / Pablo for your comments.

I'll raise a new patchset for this.

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum, a Linux Foundation Collaborative Project.

      reply	other threads:[~2016-04-28 19:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08  3:07 [PATCH iptables] xtables: use exponential delay when waiting for xtables lock Subash Abhinov Kasiviswanathan
2016-04-28  1:37 ` Liping Zhang
2016-04-28  9:25   ` Pablo Neira Ayuso
2016-04-28 19:14     ` subashab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569a5c79f8ca32db942694308c3e1500@codeaurora.org \
    --to=subashab@codeaurora.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=zlpnobody@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.