From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Andi Shyti <andi.shyti@samsung.com>, linux-samsung-soc@vger.kernel.org
Cc: Sangbeom Kim <sbkim73@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Andi Shyti <andi@etezian.org>,
Yadwinder Singh Brar <yadi.brar01@gmail.com>,
Jaehoon Chung <jh80.chung@samsung.com>
Subject: Re: [PATCH v3 0/4] s2mps11 clock driver refactoring
Date: Thu, 21 Jan 2016 09:18:20 +0900 [thread overview]
Message-ID: <56A023CC.6@samsung.com> (raw)
In-Reply-To: <1453284864-8082-1-git-send-email-andi.shyti@samsung.com>
On 20.01.2016 19:14, Andi Shyti wrote:
> Hi,
>
> This patchset contains some code refactoring on the s2mps11 clock
> device driver. The main goal is to remove some dead code and
> improve its readability.
>
> At any iteration the patchset is getting a patch more, so that
> this time there are four patches :)
Which means that if I have more comments now, you will send a v5 with 5
patches inside? Oh...
BR,
Krzysztof
>
> Thanks to Krzysztof for his review, the changset is coming from
> his suggestions:
>
> V1 -> V2
> - the order of the patches has changed
> - the second patch has been added and it merges a for loop
> inside
> a previous one
> - the 3rd patch (which in the first version was the 1st)
> contains some more redundant variables removal.
>
> V2 -> V3
> - The "merge two for loops in one" has been moved as first patch
> - removed the global variable clk_data
>
> The patches have been applied on next-20160120 and tested on
> Odroid Xu4.
>
> Andi Shyti (4):
> clk: s2mps11: merge two for loops in one
> clk: s2mps11: allocate only one structure for clock init
> clk: s2mps11: remove redundant static variables declaration
> clk: s2mps11: remove redundant code
>
> drivers/clk/clk-s2mps11.c | 108 +++++++++++++---------------------------------
> 1 file changed, 31 insertions(+), 77 deletions(-)
>
prev parent reply other threads:[~2016-01-21 0:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 10:14 [PATCH v3 0/4] s2mps11 clock driver refactoring Andi Shyti
2016-01-20 10:14 ` [PATCH v3 1/4] clk: s2mps11: merge two for loops in one Andi Shyti
2016-01-21 0:20 ` Krzysztof Kozlowski
2016-01-30 0:34 ` Stephen Boyd
2016-01-20 10:14 ` [PATCH v3 2/4] clk: s2mps11: allocate only one structure for clock init Andi Shyti
2016-01-21 0:23 ` Krzysztof Kozlowski
2016-01-30 0:34 ` Stephen Boyd
2016-01-20 10:14 ` [PATCH v3 3/4] clk: s2mps11: remove redundant static variables declaration Andi Shyti
2016-01-21 0:29 ` Krzysztof Kozlowski
2016-01-30 0:34 ` Stephen Boyd
2016-01-20 10:14 ` [PATCH v3 4/4] clk: s2mps11: remove redundant code Andi Shyti
2016-01-21 0:29 ` Krzysztof Kozlowski
2016-01-30 0:34 ` Stephen Boyd
2016-01-21 0:18 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A023CC.6@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=jh80.chung@samsung.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sbkim73@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=yadi.brar01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.